Removal of the `@types/config` package downgraded type safety · Issue #913 · node-config/node-config · GitHub
Skip to content

Removal of the @types/config package downgraded type safety #913

Description

@TurtIeSocks

Describe the bug

Regarding the removal of the external @types/config package. While I'm fully in support of packages managing their types locally instead of through DefinitelyTyped, the decision did sadden me a bit since the new V4 types removed a lot of the type safety that I introduced in #70288.

I do acknowledge that the types I added in that PR were prone to TypeScript performance issues, particularly if any types were recursive, but I have since refined my approach to typing dot notation expressions and would really love to see that kind of type safety brought back to node-config.

I'm more than happy to make a PR that restores these type definitions, but I wanted to first check to see if the maintainers are interested in this or if they no longer wish to have this kind of type safety.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions