Purge ignite by samedii · Pull Request #8 · nextml-code/ml-workflow · GitHub
Skip to content

Purge ignite#8

Draft
samedii wants to merge 5 commits into
poetryfrom
purge-ignite
Draft

Purge ignite#8
samedii wants to merge 5 commits into
poetryfrom
purge-ignite

Conversation

@samedii

@samedii samedii commented Oct 29, 2020

Copy link
Copy Markdown
Contributor

Discussion points

  • Can we make train better?
  • Can we do something to improve FeatureBatch etc?
  • Something else?

This code does not work but thought it could be useful for the discussion

@samedii samedii changed the base branch from master to poetry October 29, 2020 20:04

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*data_loader
Same typo in train-func, just fyi!

@FelixAbrahamsson

Copy link
Copy Markdown
Contributor

What do you think of building a library to replace ignite vs keeping everything in a template? I kind of like the callback system ignite uses but the more I think about building something like that the more I feel like we'd just end up replicating most of ignite.

@FelixAbrahamsson

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants