FilesExpand file tree

 main

/

ReturnConsistentTupleSizes.ql

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

35 lines (32 loc) · 1.1 KB

 main

/

ReturnConsistentTupleSizes.ql

Copy path

Top

File metadata and controls

• Code
• Blame

35 lines (32 loc) · 1.1 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

35

/**

* @name Returning tuples with varying lengths

* @description A function that potentially returns tuples of different lengths may indicate a problem.

* @kind problem

* @tags quality

* reliability

* correctness

* @problem.severity recommendation

* @sub-severity high

* @precision high

* @id py/mixed-tuple-returns

*/

import python

import semmle.python.ApiGraphs

predicate returns_tuple_of_size(Function func, int size, Tuple tuple) {

exists(Return return, DataFlow::Node value |

value.asExpr() = return.getValue() and

return.getScope() = func and

any(DataFlow::LocalSourceNode n | n.asExpr() = tuple).flowsTo(value)

|

size = count(int n | exists(tuple.getElt(n)))

)

}

from Function func, int s1, int s2, AstNode t1, AstNode t2

where

returns_tuple_of_size(func, s1, t1) and

returns_tuple_of_size(func, s2, t2) and

s1 < s2 and

// Don't report on functions that have a return type annotation

not exists(func.getDefinition().(FunctionExpr).getReturns())

select func, func.getQualifiedName() + " returns $@ and $@.", t1, "tuple of size " + s1, t2,

"tuple of size " + s2