refactor(relay): delete the SSH relay server, its build assets and te… · mvanhorn/orca@2b4b60a · GitHub
Skip to content

Commit 2b4b60a

Browse files
OrcaWinm4air
OrcaWin
and
m4air
authored
refactor(relay): delete the SSH relay server, its build assets and tests (stablyai#27215)
* wip: delete the SSH relay server and its build, assets and tests * wip: drop main/relay plugin conformance; WSL reader lookup test * fix: drop the emptied relay bench; prune baselines * test: keep the native halves of tests that also covered the relay * chore(ci): drop shard timings for the deleted relay server tests * fix: keep the directory listing budget that darwin terminal names now import --------- Co-authored-by: m4air <m4air@Mac.localdomain>
1 parent c2c63e7 commit 2b4b60a

512 files changed

Lines changed: 357 additions & 85652 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.gitattributes‎

Lines changed: 0 additions & 1 deletion

‎.github/workflows/performance-contracts.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ on:
2222
- 'src/main/codex-usage/scanner-incremental-append.test.ts'
2323
- 'src/main/usage/jsonl-file-reader.test.ts'
2424
- 'src/main/usage/jsonl-file-snapshot.test.ts'
25-
- 'src/relay/fs-path-metadata-symlink-concurrency.test.ts'
2625
- 'src/renderer/src/components/editor/rich-markdown-list-tokenizers.test.ts'
2726
- 'src/renderer/src/components/editor/rich-markdown-lowlight-cache.test.ts'
2827
- 'src/renderer/src/components/terminal-pane/agent-completion-coordinator-queued-inspection-disposal.test.ts'

‎.github/workflows/pr.yml‎

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -503,8 +503,7 @@ jobs:
503503
pnpm exec vitest run --config config/vitest.config.ts \
504504
src/shared/git-binary-compatibility.test.ts \
505505
src/main/git/worktree-safety-real-git.test.ts \
506-
src/main/git/worktree-rebase-update-refs-real-git.test.ts \
507-
src/relay/git-review-draft-binary-compatibility.test.ts
506+
src/main/git/worktree-rebase-update-refs-real-git.test.ts
508507
) &
509508
pids+=("$!")
510509
@@ -516,8 +515,7 @@ jobs:
516515
pnpm exec vitest run --config config/vitest.config.ts \
517516
src/shared/git-binary-compatibility.test.ts \
518517
src/main/git/worktree-safety-real-git.test.ts \
519-
src/main/git/worktree-rebase-update-refs-real-git.test.ts \
520-
src/relay/git-review-draft-binary-compatibility.test.ts
518+
src/main/git/worktree-rebase-update-refs-real-git.test.ts
521519
) &
522520
pids+=("$!")
523521
done
@@ -792,7 +790,6 @@ jobs:
792790
src/main/terminal-history-fish-session.node-pty.test.ts \
793791
src/main/zsh-scoped-histfile.live-shell.test.ts \
794792
src/main/zsh-startup-hook-user-config-equivalence.live-shell.test.ts \
795-
src/main/zsh-wrapper-version-mismatch.live-shell.test.ts \
796793
src/main/runtime/structured-session-cli-login-shell.live-shell.test.ts \
797794
src/renderer/src/components/terminal-pane/fish-color-scheme-child-stdin.node-pty.test.ts \
798795
src/shared/fish-query-reply-child-stdin.node-pty.test.ts \
@@ -969,17 +966,11 @@ jobs:
969966

970967
- uses: ./.github/actions/install-node-dependencies
971968

972-
- name: Build relay companions
973-
run: pnpm run build:relay
974-
975969
- name: Setup Node 18 runtime
976970
uses: actions/setup-node@v6
977971
with:
978972
node-version: '18'
979973

980-
- name: Smoke managed-hook companions
981-
run: node config/scripts/smoke-managed-hook-runtime-node18.mjs
982-
983974
# The process-host package declares engines >=18; load its staged public output on Node 18.
984975
- name: Smoke process-host package
985976
run: node config/scripts/smoke-process-host-node18.mjs
@@ -1270,9 +1261,7 @@ jobs:
12701261
src/main/ipc/pty-spawn-env-codex-resume-provenance.test.ts
12711262
src/main/ipc/preflight-provider-command-selection.test.ts
12721263
src/main/ipc/preflight-runnable-local-cli.test.ts
1273-
src/relay/windows-port-scan.win32.test.ts
12741264
src/main/ssh/remote-node-runtime-store-windows.test.ts
1275-
config/scripts/node-pty-windows-pty-teardown-patch.test.mjs
12761265
12771266
# Why the :parallel variant: identical to build:release except the three
12781267
# electron-vite targets overlap instead of running back to back. The Linux package

‎.github/workflows/release-cut.yml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1520,12 +1520,6 @@ jobs:
15201520
node config/scripts/runtime-file-watcher-fault-harness.mjs
15211521
ELECTRON_RUN_AS_NODE=1 pnpm exec electron config/scripts/runtime-file-watcher-fault-harness.mjs
15221522
1523-
- name: Gate SSH relay watcher process isolation
1524-
run: |
1525-
# Why: the remote native watcher shares a daemon with live PTYs.
1526-
# Kill only its child and require both PTY and watch recovery before packaging.
1527-
node config/scripts/relay-watcher-fault-harness.mjs
1528-
15291523
# Why: main ships minified with sourcemap:'hidden' and packaging drops
15301524
# out/**/*.map from app.asar, so a crash trace from a released build is
15311525
# otherwise undecodable. The main bundle is platform-independent, so one

‎.github/workflows/release-mac-build.yml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -195,12 +195,6 @@ jobs:
195195
node config/scripts/runtime-file-watcher-fault-harness.mjs
196196
ELECTRON_RUN_AS_NODE=1 pnpm exec electron config/scripts/runtime-file-watcher-fault-harness.mjs
197197
198-
- name: Gate SSH relay watcher process isolation
199-
run: |
200-
# Why: the remote native watcher shares a daemon with live PTYs.
201-
# Kill only its child and require both PTY and watch recovery before packaging.
202-
node config/scripts/relay-watcher-fault-harness.mjs
203-
204198
- name: Abort if the parent release-cut run was cancelled
205199
# Why: this workflow is dispatched separately, so cancelling release-cut
206200
# does not stop mac `--publish always`. A cancelled parent left v1.4.206

‎.github/workflows/ssh-hostile-hosts.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ on:
1616
- 'src/main/ssh/ssh-remote-*'
1717
- 'src/main/ssh/ssh-hostile-host-*'
1818
- 'src/main/ssh/sftp-*'
19-
- 'src/relay/**'
2019
- 'src/wsl-guest/**'
2120
- 'src/shared/node-runtime-pin.ts'
2221
- 'src/shared/orcad-artifacts.ts'

‎.github/workflows/ssh-windows-hosts.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ on:
1717
- 'src/main/ssh/ssh-hostile-host-*'
1818
- 'src/main/ssh/ssh-windows-host-*'
1919
- 'src/main/ssh/ssh-session-command-audit.ts'
20-
- 'src/relay/**'
2120
- 'src/wsl-guest/**'
2221
- 'src/packages/process-host/**'
2322
- 'pnpm-workspace.yaml'
@@ -35,7 +34,6 @@ on:
3534
- 'config/patches/node-pty*'
3635
- 'config/patches/@vscode__windows-process-tree*'
3736
- 'config/scripts/build-windows-process-tree-relay-addon.mjs'
38-
- 'config/scripts/relay-windows-process-tree-staging.mjs'
3937
- 'config/scripts/relay-windows-process-tree-prepared-addon*.mjs'
4038
- 'config/scripts/windows-process-tree-gyp-rebuild.mjs'
4139
- 'src/shared/relay-windows-breakaway-launch.ts'

‎config/ci/windows-ssh-provider/invoke-pinned-relay-cells.ps1‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ function Invoke-AppCell($Account,[string]$Descriptor,[string]$Log,[string]$Spec,
9292
New-Item -ItemType Directory -Force -Path $ReceiptRoot | Out-Null
9393
Push-Location $SourceRoot
9494
try {
95-
if(-not (Test-Path -LiteralPath "out\relay\$Target\relay.js")){throw 'Build the relay before provisioning'}
9695
if(-not (Test-Path -LiteralPath 'out\orcad-template')){throw 'Build the orcad template before provisioning'}
9796
# ssh2 consults the runner's known_hosts: pin only this private endpoint, restored below.
9897
New-Item -ItemType Directory -Force -Path (Split-Path $knownPath) | Out-Null

‎config/knip.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
"src/renderer/src/web/main.tsx",
2121
"src/renderer/src/**/*.worker.ts",
2222
"src/cli/index.ts",
23-
"src/relay/relay.ts",
2423
"src/wsl-guest/wsl-agent-hook-relay.ts",
2524
"config/scripts/**/*.{mjs,cjs,js,ts}",
2625
"config/build-plugins/**/*.ts",

‎config/max-lines-baseline.txt‎

Lines changed: 0 additions & 1 deletion

0 commit comments

Comments
 (0)