Merge pull request #50764 from austinvazquez/move-disk-usage-types-to… · moby/moby@c8c4996 · GitHub
Skip to content

Commit c8c4996

Browse files
authored
Merge pull request #50764 from austinvazquez/move-disk-usage-types-to-daemon-backend
api/types: move disk usage structs to daemon backend
2 parents 0476bb6 + c4e82ba commit c8c4996

12 files changed

Lines changed: 42 additions & 80 deletions

File tree

‎api/types/build/disk_usage.go‎

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎api/types/container/disk_usage.go‎

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎api/types/image/disk_usage.go‎

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎api/types/volume/disk_usage.go‎

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎daemon/daemon.go‎

Lines changed: 2 additions & 3 deletions

‎daemon/disk_usage.go‎

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,15 @@ import (
77
"github.com/moby/moby/api/types/container"
88
"github.com/moby/moby/api/types/filters"
99
"github.com/moby/moby/api/types/image"
10-
"github.com/moby/moby/api/types/volume"
1110
"github.com/moby/moby/v2/daemon/server/backend"
1211
"github.com/pkg/errors"
1312
"golang.org/x/sync/errgroup"
1413
)
1514

1615
// containerDiskUsage obtains information about container data disk usage
1716
// and makes sure that only one calculation is performed at the same time.
18-
func (daemon *Daemon) containerDiskUsage(ctx context.Context) (*container.DiskUsage, error) {
19-
res, _, err := daemon.usageContainers.Do(ctx, struct{}{}, func(ctx context.Context) (*container.DiskUsage, error) {
17+
func (daemon *Daemon) containerDiskUsage(ctx context.Context) (*backend.ContainerDiskUsage, error) {
18+
res, _, err := daemon.usageContainers.Do(ctx, struct{}{}, func(ctx context.Context) (*backend.ContainerDiskUsage, error) {
2019
// Retrieve container list
2120
containers, err := daemon.Containers(ctx, &container.ListOptions{
2221
Size: true,
@@ -38,7 +37,7 @@ func (daemon *Daemon) containerDiskUsage(ctx context.Context) (*container.DiskUs
3837
ctr.State == container.StateRestarting
3938
}
4039

41-
du := &container.DiskUsage{Items: containers}
40+
du := &backend.ContainerDiskUsage{Items: containers}
4241
for _, ctr := range du.Items {
4342
du.TotalSize += ctr.SizeRw
4443
if !isActive(ctr) {
@@ -70,14 +69,14 @@ func (daemon *Daemon) imageDiskUsage(ctx context.Context) ([]*image.Summary, err
7069

7170
// localVolumesSize obtains information about volume disk usage from volumes service
7271
// and makes sure that only one size calculation is performed at the same time.
73-
func (daemon *Daemon) localVolumesSize(ctx context.Context) (*volume.DiskUsage, error) {
74-
volumes, _, err := daemon.usageVolumes.Do(ctx, struct{}{}, func(ctx context.Context) (*volume.DiskUsage, error) {
72+
func (daemon *Daemon) localVolumesSize(ctx context.Context) (*backend.VolumeDiskUsage, error) {
73+
volumes, _, err := daemon.usageVolumes.Do(ctx, struct{}{}, func(ctx context.Context) (*backend.VolumeDiskUsage, error) {
7574
volumes, err := daemon.volumes.LocalVolumesSize(ctx)
7675
if err != nil {
7776
return nil, err
7877
}
7978

80-
du := &volume.DiskUsage{Items: volumes}
79+
du := &backend.VolumeDiskUsage{Items: volumes}
8180
for _, v := range du.Items {
8281
if v.UsageData.Size != -1 {
8382
if v.UsageData.RefCount == 0 {
@@ -150,7 +149,7 @@ func (daemon *Daemon) SystemDiskUsage(ctx context.Context, opts backend.DiskUsag
150149
}
151150
}
152151

153-
du.Images = &image.DiskUsage{
152+
du.Images = &backend.ImageDiskUsage{
154153
TotalSize: layersSize,
155154
Reclaimable: reclaimable,
156155
Items: images,

‎daemon/server/backend/disk_usage.go‎

Lines changed: 32 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,36 @@ type DiskUsageOptions struct {
2222
// DiskUsage contains the information returned by the backend for the
2323
// GET "/system/df" endpoint.
2424
type DiskUsage struct {
25-
Images *image.DiskUsage
26-
Containers *container.DiskUsage
27-
Volumes *volume.DiskUsage
28-
BuildCache *build.CacheDiskUsage
25+
Images *ImageDiskUsage
26+
Containers *ContainerDiskUsage
27+
Volumes *VolumeDiskUsage
28+
BuildCache *BuildCacheDiskUsage
29+
}
30+
31+
// BuildCacheDiskUsage contains disk usage for the build cache.
32+
type BuildCacheDiskUsage struct {
33+
TotalSize int64
34+
Reclaimable int64
35+
Items []*build.CacheRecord
36+
}
37+
38+
// ContainerDiskUsage contains disk usage for containers.
39+
type ContainerDiskUsage struct {
40+
TotalSize int64
41+
Reclaimable int64
42+
Items []*container.Summary
43+
}
44+
45+
// ImageDiskUsage contains disk usage for images.
46+
type ImageDiskUsage struct {
47+
TotalSize int64
48+
Reclaimable int64
49+
Items []*image.Summary
50+
}
51+
52+
// VolumeDiskUsage contains disk usage for volumes.
53+
type VolumeDiskUsage struct {
54+
TotalSize int64
55+
Reclaimable int64
56+
Items []*volume.Volume
2957
}

‎daemon/server/router/system/system_routes.go‎

Lines changed: 1 addition & 1 deletion

‎vendor/github.com/moby/moby/api/types/build/disk_usage.go‎

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎vendor/github.com/moby/moby/api/types/container/disk_usage.go‎

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)