api: info: omit deprecated "Commit.Expected" fields on API >= 1.49 · moby/moby@564abf9 · GitHub
Skip to content

Commit 564abf9

Browse files
committed
api: info: omit deprecated "Commit.Expected" fields on API >= 1.49
These fields were deprecated in ff191c5, and are now omitted. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent ba12b2d commit 564abf9

5 files changed

Lines changed: 42 additions & 22 deletions

File tree

‎api/server/router/system/system_routes.go‎

Lines changed: 7 additions & 5 deletions

‎api/swagger.yaml‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7186,13 +7186,6 @@ definitions:
71867186
description: "Actual commit ID of external tool."
71877187
type: "string"
71887188
example: "cfb82a876ecc11b5ca0977d1733adbe58599088a"
7189-
Expected:
7190-
description: |
7191-
Commit ID of external tool expected by dockerd as set at build time.
7192-
7193-
**Deprecated**: This field is deprecated and will be omitted in a API v1.49.
7194-
type: "string"
7195-
example: "2d41c047c83e09a6d61d464906feb2a2f3c52aa4"
71967189

71977190
SwarmInfo:
71987191
description: |

‎api/types/system/info.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ type Commit struct {
144144
// Expected is the commit ID of external tool expected by dockerd as set at build time.
145145
//
146146
// Deprecated: this field is no longer used in API v1.49, but kept for backward-compatibility with older API versions.
147-
Expected string
147+
Expected string `json:",omitempty"`
148148
}
149149

150150
// NetworkAddressPool is a temp struct used by [Info] struct.

‎docs/api/version-history.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ keywords: "API, Docker, rcli, REST, documentation"
2626
* Deprecated: The `AllowNondistributableArtifactsCIDRs` and `AllowNondistributableArtifactsHostnames`
2727
fields in the `RegistryConfig` struct in the `GET /info` response are omitted
2828
in API v1.49.
29+
* Deprecated: The `ContainerdCommit.Expected`, `RuncCommit.Expected`, and
30+
`InitCommit.Expected` fields in the `GET /info` endpoint were deprecated
31+
in API v1.48, and are now omitted in API v1.49.
2932

3033
## v1.48 API changes
3134

‎integration/system/info_linux_test.go‎

Lines changed: 31 additions & 9 deletions

0 commit comments

Comments
 (0)