{{ message }}
Repository navigation
Expand file tree
/
Copy pathdocker_cli_by_digest_test.go
More file actions
598 lines (447 loc) · 22.1 KB
/
Copy pathdocker_cli_by_digest_test.go
File metadata and controls
598 lines (447 loc) · 22.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
package main
import (
"encoding/json"
"fmt"
"os"
"path/filepath"
"regexp"
"strings"
"testing"
"github.com/moby/moby/api/types/image"
"github.com/moby/moby/v2/integration-cli/cli"
"github.com/moby/moby/v2/integration-cli/cli/build"
"github.com/opencontainers/go-digest"
ocispec "github.com/opencontainers/image-spec/specs-go/v1"
"gotest.tools/v3/assert"
is "gotest.tools/v3/assert/cmp"
"gotest.tools/v3/skip"
)
const (
remoteRepoName = "dockercli/busybox-by-dgst"
repoName = privateRegistryURL + "/" + remoteRepoName
)
var (
pushDigestRegex = regexp.MustCompile(`[\S]+: digest: ([\S]+) size: [0-9]+`)
digestRegex = regexp.MustCompile(`Digest: ([\S]+)`)
)
func setupImage(t *testing.T) (digest.Digest, error) {
return setupImageWithTag(t, "latest")
}
func setupImageWithTag(t *testing.T, tag string) (digest.Digest, error) {
const containerName = "busyboxbydigest"
// new file is committed because this layer is used for detecting malicious
// changes. if this was committed as empty layer it would be skipped on pull
// and malicious changes would never be detected.
cli.DockerCmd(t, "run", "-e", "digest=1", "--name", containerName, "busybox", "touch", "anewfile")
// tag the image to upload it to the private registry
repoAndTag := repoName + ":" + tag
cli.DockerCmd(t, "commit", containerName, repoAndTag)
// delete the container as we don't need it any more
cli.DockerCmd(t, "rm", "-fv", containerName)
// push the image
out := cli.DockerCmd(t, "push", repoAndTag).Combined()
// delete our local repo that we previously tagged
cli.DockerCmd(t, "rmi", repoAndTag)
matches := pushDigestRegex.FindStringSubmatch(out)
assert.Equal(t, len(matches), 2, "unable to parse digest from push output: %s", out)
pushDigest := matches[1]
return digest.Digest(pushDigest), nil
}
func (s *DockerRegistrySuite) TestPullByTagDisplaysDigest(t *testing.T) {
testRequires(t, DaemonIsLinux)
pushDigest, err := setupImage(t)
assert.NilError(t, err, "error setting up image")
// pull from the registry using the tag
out := cli.DockerCmd(t, "pull", repoName).Combined()
// the pull output includes "Digest: <digest>", so find that
matches := digestRegex.FindStringSubmatch(out)
assert.Equal(t, len(matches), 2, "unable to parse digest from push output: %s", out)
pullDigest := matches[1]
// make sure the pushed and pull digests match
assert.Equal(t, pushDigest.String(), pullDigest)
}
func (s *DockerRegistrySuite) TestPullByDigest(t *testing.T) {
testRequires(t, DaemonIsLinux)
pushDigest, err := setupImage(t)
assert.NilError(t, err, "error setting up image")
// pull from the registry using the <name>@<digest> reference
imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
out := cli.DockerCmd(t, "pull", imageReference).Combined()
// the pull output includes "Digest: <digest>", so find that
matches := digestRegex.FindStringSubmatch(out)
assert.Equal(t, len(matches), 2, "unable to parse digest from push output: %s", out)
pullDigest := matches[1]
// make sure the pushed and pull digests match
assert.Equal(t, pushDigest.String(), pullDigest)
}
func (s *DockerRegistrySuite) TestPullByDigestNoFallback(t *testing.T) {
testRequires(t, DaemonIsLinux)
// pull from the registry using the <name>@<digest> reference
imageReference := repoName + "@sha256:ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"
out, _, err := dockerCmdWithError("pull", imageReference)
assert.Assert(t, err != nil, "expected non-zero exit status and correct error message when pulling non-existing image")
expectedMsg := fmt.Sprintf("manifest for %s not found", imageReference)
if testEnv.UsingSnapshotter() {
expectedMsg = imageReference + ": not found"
}
assert.Check(t, is.Contains(out, expectedMsg), "expected non-zero exit status and correct error message when pulling non-existing image")
}
func (s *DockerRegistrySuite) TestCreateByDigest(t *testing.T) {
pushDigest, err := setupImage(t)
assert.NilError(t, err, "error setting up image")
imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
const containerName = "createByDigest"
cli.DockerCmd(t, "create", "--name", containerName, imageReference)
res := inspectField(t, containerName, "Config.Image")
assert.Equal(t, res, imageReference)
}
func (s *DockerRegistrySuite) TestRunByDigest(t *testing.T) {
pushDigest, err := setupImage(t)
assert.NilError(t, err)
imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
const containerName = "runByDigest"
out := cli.DockerCmd(t, "run", "--name", containerName, imageReference, "sh", "-c", "echo found=$digest").Combined()
foundRegex := regexp.MustCompile("found=([^\n]+)")
matches := foundRegex.FindStringSubmatch(out)
assert.Equal(t, len(matches), 2, "unable to parse digest from pull output: "+out)
assert.Equal(t, matches[1], "1", fmt.Sprintf("Expected %q, got %q", "1", matches[1]))
res := inspectField(t, containerName, "Config.Image")
assert.Equal(t, res, imageReference)
}
func (s *DockerRegistrySuite) TestRemoveImageByDigest(t *testing.T) {
imgDigest, err := setupImage(t)
assert.NilError(t, err, "error setting up image")
imageReference := fmt.Sprintf("%s@%s", repoName, imgDigest)
// pull from the registry using the <name>@<digest> reference
cli.DockerCmd(t, "pull", imageReference)
// make sure inspect runs ok
inspectField(t, imageReference, "Id")
// do the delete
err = deleteImages(imageReference)
assert.NilError(t, err, "unexpected error deleting image")
// try to inspect again - it should error this time
_, err = inspectFilter(imageReference, ".Id")
// unexpected nil err trying to inspect what should be a non-existent image
assert.ErrorContains(t, err, "No such object")
}
func (s *DockerRegistrySuite) TestBuildByDigest(t *testing.T) {
imgDigest, err := setupImage(t)
assert.NilError(t, err, "error setting up image")
imageReference := fmt.Sprintf("%s@%s", repoName, imgDigest)
// pull from the registry using the <name>@<digest> reference
cli.DockerCmd(t, "pull", imageReference)
// do the build
const name = "buildbydigest"
cli.BuildCmd(t, name, build.WithDockerfile(fmt.Sprintf(
`FROM %s
CMD ["/bin/echo", "Hello World"]`, imageReference)))
assert.NilError(t, err)
// verify the build was ok
res := inspectField(t, name, "Config.Cmd")
assert.Equal(t, res, `[/bin/echo Hello World]`)
}
func (s *DockerRegistrySuite) TestTagByDigest(t *testing.T) {
imgDigest, err := setupImage(t)
assert.NilError(t, err, "error setting up image")
imageReference := fmt.Sprintf("%s@%s", repoName, imgDigest)
// pull from the registry using the <name>@<digest> reference
cli.DockerCmd(t, "pull", imageReference)
// tag it
const tag = "tagbydigest"
cli.DockerCmd(t, "tag", imageReference, tag)
expectedID := inspectField(t, imageReference, "Id")
tagID := inspectField(t, tag, "Id")
assert.Equal(t, tagID, expectedID)
}
func (s *DockerRegistrySuite) TestListImagesWithoutDigests(t *testing.T) {
imgDigest, err := setupImage(t)
assert.NilError(t, err, "error setting up image")
imageReference := fmt.Sprintf("%s@%s", repoName, imgDigest)
// pull from the registry using the <name>@<digest> reference
cli.DockerCmd(t, "pull", imageReference)
out := cli.DockerCmd(t, "images").Stdout()
assert.Assert(t, !strings.Contains(out, "DIGEST"), "list output should not have contained DIGEST header")
}
func (s *DockerRegistrySuite) TestListImagesWithDigests(t *testing.T) {
// setup image1
digest1, err := setupImageWithTag(t, "tag1")
assert.NilError(t, err, "error setting up image")
imageReference1 := fmt.Sprintf("%s@%s", repoName, digest1)
t.Logf("imageReference1 = %s", imageReference1)
// pull image1 by digest
cli.DockerCmd(t, "pull", imageReference1)
// list images
out := cli.DockerCmd(t, "images", "--digests").Combined()
// make sure repo shown, tag=<none>, digest = $digest1
re1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1.String() + `\s`)
assert.Assert(t, re1.MatchString(out), "expected %q: %s", re1.String(), out)
// setup image2
digest2, err := setupImageWithTag(t, "tag2")
assert.NilError(t, err, "error setting up image")
imageReference2 := fmt.Sprintf("%s@%s", repoName, digest2)
t.Logf("imageReference2 = %s", imageReference2)
// pull image1 by digest
cli.DockerCmd(t, "pull", imageReference1)
// pull image2 by digest
cli.DockerCmd(t, "pull", imageReference2)
// list images
out = cli.DockerCmd(t, "images", "--digests").Stdout()
// make sure repo shown, tag=<none>, digest = $digest1
assert.Assert(t, re1.MatchString(out), "expected %q: %s", re1.String(), out)
// make sure repo shown, tag=<none>, digest = $digest2
re2 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest2.String() + `\s`)
assert.Assert(t, re2.MatchString(out), "expected %q: %s", re2.String(), out)
// pull tag1
cli.DockerCmd(t, "pull", repoName+":tag1")
// list images
out = cli.DockerCmd(t, "images", "--digests").Stdout()
// make sure image 1 has repo, tag, <none> AND repo, <none>, digest
reWithDigest1 := regexp.MustCompile(`\s*` + repoName + `\s*tag1\s*` + digest1.String() + `\s`)
assert.Assert(t, reWithDigest1.MatchString(out), "expected %q: %s", reWithDigest1.String(), out)
// make sure image 2 has repo, <none>, digest
assert.Assert(t, re2.MatchString(out), "expected %q: %s", re2.String(), out)
// pull tag 2
cli.DockerCmd(t, "pull", repoName+":tag2")
// list images
out = cli.DockerCmd(t, "images", "--digests").Stdout()
// make sure image 1 has repo, tag, digest
assert.Assert(t, reWithDigest1.MatchString(out), "expected %q: %s", reWithDigest1.String(), out)
// make sure image 2 has repo, tag, digest
reWithDigest2 := regexp.MustCompile(`\s*` + repoName + `\s*tag2\s*` + digest2.String() + `\s`)
assert.Assert(t, reWithDigest2.MatchString(out), "expected %q: %s", reWithDigest2.String(), out)
// list images
out = cli.DockerCmd(t, "images", "--digests").Stdout()
// make sure image 1 has repo, tag, digest
assert.Assert(t, reWithDigest1.MatchString(out), "expected %q: %s", reWithDigest1.String(), out)
// make sure image 2 has repo, tag, digest
assert.Assert(t, reWithDigest2.MatchString(out), "expected %q: %s", reWithDigest2.String(), out)
// We always have a digest when using containerd to store images
if !testEnv.UsingSnapshotter() {
// make sure busybox has tag, but not digest
busyboxRe := regexp.MustCompile(`\s*busybox\s*latest\s*<none>\s`)
assert.Assert(t, busyboxRe.MatchString(out), "expected %q: %s", busyboxRe.String(), out)
}
}
func (s *DockerRegistrySuite) TestListDanglingImagesWithDigests(t *testing.T) {
// See https://github.com/moby/moby/pull/46856
skip.If(t, testEnv.UsingSnapshotter(), "dangling=true filter behaves a bit differently with c8d")
// setup image1
digest1, err := setupImageWithTag(t, "dangle1")
assert.NilError(t, err, "error setting up image")
imageReference1 := fmt.Sprintf("%s@%s", repoName, digest1)
t.Logf("imageReference1 = %s", imageReference1)
// pull image1 by digest
cli.DockerCmd(t, "pull", imageReference1)
// list images
out := cli.DockerCmd(t, "images", "--digests").Stdout()
// make sure repo shown, tag=<none>, digest = $digest1
re1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1.String() + `\s`)
assert.Assert(t, re1.MatchString(out), "expected %q: %s", re1.String(), out)
// setup image2
digest2, err := setupImageWithTag(t, "dangle2")
// error setting up image
assert.NilError(t, err)
imageReference2 := fmt.Sprintf("%s@%s", repoName, digest2)
t.Logf("imageReference2 = %s", imageReference2)
// pull image1 by digest
cli.DockerCmd(t, "pull", imageReference1)
// pull image2 by digest
cli.DockerCmd(t, "pull", imageReference2)
// list images
out = cli.DockerCmd(t, "images", "--digests", "--filter=dangling=true").Stdout()
// make sure repo shown, tag=<none>, digest = $digest1
assert.Assert(t, re1.MatchString(out), "expected %q: %s", re1.String(), out)
// make sure repo shown, tag=<none>, digest = $digest2
re2 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest2.String() + `\s`)
assert.Assert(t, re2.MatchString(out), "expected %q: %s", re2.String(), out)
// pull dangle1 tag
cli.DockerCmd(t, "pull", repoName+":dangle1")
// list images
out = cli.DockerCmd(t, "images", "--digests", "--filter=dangling=true").Stdout()
// make sure image 1 has repo, tag, <none> AND repo, <none>, digest
reWithDigest1 := regexp.MustCompile(`\s*` + repoName + `\s*dangle1\s*` + digest1.String() + `\s`)
assert.Assert(t, !reWithDigest1.MatchString(out), "unexpected %q: %s", reWithDigest1.String(), out)
// make sure image 2 has repo, <none>, digest
assert.Assert(t, re2.MatchString(out), "expected %q: %s", re2.String(), out)
// pull dangle2 tag
cli.DockerCmd(t, "pull", repoName+":dangle2")
// list images, show tagged images
out = cli.DockerCmd(t, "images", "--digests").Stdout()
// make sure image 1 has repo, tag, digest
assert.Assert(t, reWithDigest1.MatchString(out), "expected %q: %s", reWithDigest1.String(), out)
// make sure image 2 has repo, tag, digest
reWithDigest2 := regexp.MustCompile(`\s*` + repoName + `\s*dangle2\s*` + digest2.String() + `\s`)
assert.Assert(t, reWithDigest2.MatchString(out), "expected %q: %s", reWithDigest2.String(), out)
// list images, no longer dangling, should not match
out = cli.DockerCmd(t, "images", "--digests", "--filter=dangling=true").Stdout()
// make sure image 1 has repo, tag, digest
assert.Assert(t, !reWithDigest1.MatchString(out), "unexpected %q: %s", reWithDigest1.String(), out)
// make sure image 2 has repo, tag, digest
assert.Assert(t, !reWithDigest2.MatchString(out), "unexpected %q: %s", reWithDigest2.String(), out)
}
func (s *DockerRegistrySuite) TestInspectImageWithDigests(t *testing.T) {
imgDigest, err := setupImage(t)
assert.Assert(t, err == nil, "error setting up image")
imageReference := fmt.Sprintf("%s@%s", repoName, imgDigest)
// pull from the registry using the <name>@<digest> reference
cli.DockerCmd(t, "pull", imageReference)
out := cli.DockerCmd(t, "inspect", imageReference).Stdout()
var imageJSON []image.InspectResponse
err = json.Unmarshal([]byte(out), &imageJSON)
assert.NilError(t, err)
assert.Equal(t, len(imageJSON), 1)
assert.Equal(t, len(imageJSON[0].RepoDigests), 1)
assert.Check(t, is.Contains(imageJSON[0].RepoDigests, imageReference))
}
func (s *DockerRegistrySuite) TestPsListContainersFilterAncestorImageByDigest(t *testing.T) {
existingContainers := ExistingContainerIDs(t)
imgDigest, err := setupImage(t)
assert.NilError(t, err, "error setting up image")
imageReference := fmt.Sprintf("%s@%s", repoName, imgDigest)
// pull from the registry using the <name>@<digest> reference
cli.DockerCmd(t, "pull", imageReference)
// build an image from it
const imageName1 = "images_ps_filter_test"
cli.BuildCmd(t, imageName1, build.WithDockerfile(fmt.Sprintf(
`FROM %s
LABEL match me 1`, imageReference)),
build.WithBuildkit(false), // FIXME(thaJeztah): rewrite test to have something more predictable
)
// run a container based on that
cli.DockerCmd(t, "run", "--name=test1", imageReference, "echo", "hello")
expectedID := getIDByName(t, "test1")
// run a container based on the a descendant of that too
cli.DockerCmd(t, "run", "--name=test2", imageName1, "echo", "hello")
expectedID1 := getIDByName(t, "test2")
expectedIDs := []string{expectedID, expectedID1}
// Invalid imageReference
out := cli.DockerCmd(t, "ps", "-a", "-q", "--no-trunc", fmt.Sprintf("--filter=ancestor=busybox@%s", imgDigest)).Stdout()
assert.Equal(t, strings.TrimSpace(out), "", "Filter container for ancestor filter should be empty")
// Valid imageReference
out = cli.DockerCmd(t, "ps", "-a", "-q", "--no-trunc", "--filter=ancestor="+imageReference).Stdout()
checkPsAncestorFilterOutput(t, RemoveOutputForExistingElements(out, existingContainers), imageReference, expectedIDs)
}
func (s *DockerRegistrySuite) TestDeleteImageByIDOnlyPulledByDigest(t *testing.T) {
pushDigest, err := setupImage(t)
assert.NilError(t, err, "error setting up image")
// pull from the registry using the <name>@<digest> reference
imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
cli.DockerCmd(t, "pull", imageReference)
// just in case...
cli.DockerCmd(t, "tag", imageReference, repoName+":sometag")
imageID := inspectField(t, imageReference, "Id")
cli.DockerCmd(t, "rmi", imageID)
_, err = inspectFilter(imageID, ".Id")
assert.ErrorContains(t, err, "", "image should have been deleted")
}
func (s *DockerRegistrySuite) TestDeleteImageWithDigestAndTag(t *testing.T) {
pushDigest, err := setupImage(t)
assert.NilError(t, err, "error setting up image")
// pull from the registry using the <name>@<digest> reference
imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
cli.DockerCmd(t, "pull", imageReference)
imageID := inspectField(t, imageReference, "Id")
const repoTag = repoName + ":sometag"
const repoTag2 = repoName + ":othertag"
cli.DockerCmd(t, "tag", imageReference, repoTag)
cli.DockerCmd(t, "tag", imageReference, repoTag2)
cli.DockerCmd(t, "rmi", repoTag2)
// rmi should have deleted only repoTag2, because there's another tag
inspectField(t, repoTag, "Id")
cli.DockerCmd(t, "rmi", repoTag)
// rmi should have deleted the tag, the digest reference, and the image itself
_, err = inspectFilter(imageID, ".Id")
assert.ErrorContains(t, err, "", "image should have been deleted")
}
func (s *DockerRegistrySuite) TestDeleteImageWithDigestAndMultiRepoTag(t *testing.T) {
pushDigest, err := setupImage(t)
assert.NilError(t, err, "error setting up image")
repo2 := fmt.Sprintf("%s/%s", repoName, "repo2")
// pull from the registry using the <name>@<digest> reference
imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
cli.DockerCmd(t, "pull", imageReference)
imageID := inspectField(t, imageReference, "Id")
repoTag := repoName + ":sometag"
repoTag2 := repo2 + ":othertag"
cli.DockerCmd(t, "tag", imageReference, repoTag)
cli.DockerCmd(t, "tag", imageReference, repoTag2)
cli.DockerCmd(t, "rmi", repoTag)
// rmi should have deleted repoTag and image reference, but left repoTag2
inspectField(t, repoTag2, "Id")
_, err = inspectFilter(imageReference, ".Id")
assert.ErrorContains(t, err, "", "image digest reference should have been removed")
_, err = inspectFilter(repoTag, ".Id")
assert.ErrorContains(t, err, "", "image tag reference should have been removed")
cli.DockerCmd(t, "rmi", repoTag2)
// rmi should have deleted the tag, the digest reference, and the image itself
_, err = inspectFilter(imageID, ".Id")
assert.ErrorContains(t, err, "", "image should have been deleted")
}
// TestPullFailsWithAlteredManifest tests that a `docker pull` fails when
// we have modified a manifest blob and its digest cannot be verified.
// This is the schema2 version of the test.
func (s *DockerRegistrySuite) TestPullFailsWithAlteredManifest(t *testing.T) {
testRequires(t, DaemonIsLinux)
manifestDigest, err := setupImage(t)
assert.NilError(t, err, "error setting up image")
// Load the target manifest blob.
manifestBlob := s.reg.ReadBlobContents(t, manifestDigest)
var imgManifest ocispec.Manifest
err = json.Unmarshal(manifestBlob, &imgManifest)
assert.NilError(t, err, "unable to decode image manifest from blob")
// Change a layer in the manifest.
imgManifest.Layers[0].Digest = digest.Digest("sha256:0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef")
// Move the existing data file aside, so that we can replace it with a
// malicious blob of data. NOTE: we defer the returned undo func.
undo := s.reg.TempMoveBlobData(t, manifestDigest)
defer undo()
alteredManifestBlob, err := json.MarshalIndent(imgManifest, "", " ")
assert.NilError(t, err, "unable to encode altered image manifest to JSON")
s.reg.WriteBlobContents(t, manifestDigest, alteredManifestBlob)
// Now try pulling that image by digest. We should get an error about
// digest verification for the manifest digest.
// Pull from the registry using the <name>@<digest> reference.
imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
assert.Assert(t, exitStatus != 0)
if testEnv.UsingSnapshotter() {
assert.Assert(t, is.Contains(out, "unexpected commit digest"))
assert.Assert(t, is.Contains(out, "expected "+manifestDigest))
} else {
assert.Assert(t, is.Contains(out, fmt.Sprintf("manifest verification failed for digest %s", manifestDigest)))
}
}
// TestPullFailsWithAlteredLayer tests that a `docker pull` fails when
// we have modified a layer blob and its digest cannot be verified.
// This is the schema2 version of the test.
func (s *DockerRegistrySuite) TestPullFailsWithAlteredLayer(t *testing.T) {
testRequires(t, DaemonIsLinux)
skip.If(t, testEnv.UsingSnapshotter(), "Faked layer is already in the content store, so it won't be fetched from the repository at all.")
manifestDigest, err := setupImage(t)
assert.NilError(t, err)
// Load the target manifest blob.
manifestBlob := s.reg.ReadBlobContents(t, manifestDigest)
var imgManifest ocispec.Manifest
err = json.Unmarshal(manifestBlob, &imgManifest)
assert.NilError(t, err)
// Next, get the digest of one of the layers from the manifest.
targetLayerDigest := imgManifest.Layers[0].Digest
// Move the existing data file aside, so that we can replace it with a
// malicious blob of data. NOTE: we defer the returned undo func.
undo := s.reg.TempMoveBlobData(t, targetLayerDigest)
defer undo()
// Now make a fake data blob in this directory.
s.reg.WriteBlobContents(t, targetLayerDigest, []byte("This is not the data you are looking for."))
// Now try pulling that image by digest. We should get an error about
// digest verification for the target layer digest.
// Remove distribution cache to force a re-pull of the blobs
if err := os.RemoveAll(filepath.Join(testEnv.DaemonInfo.DockerRootDir, "image", s.d.StorageDriver(), "distribution")); err != nil {
t.Fatalf("error clearing distribution cache: %v", err)
}
// Pull from the registry using the <name>@<digest> reference.
imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
assert.Assert(t, exitStatus != 0, "expected a non-zero exit status")
expectedErrorMsg := fmt.Sprintf("filesystem layer verification failed for digest %s", targetLayerDigest)
assert.Assert(t, strings.Contains(out, expectedErrorMsg), "expected error message in output: %s", out)
}
You can’t perform that action at this time.