Comparing Aaron-Bo:main...mmmmmm44:main · Aaron-Bo/VTuber-Python-Unity · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Aaron-Bo/VTuber-Python-Unity
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: mmmmmm44/VTuber-Python-Unity
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 8 files changed
  • 2 contributors

Commits on May 14, 2022

  1. Custom port is supported in TCP

    Added an argument to allow user input the port connected to unity,
    such that multiple instances are now supported (though the situation is rare.)
    
    Added error handling code if error occurs when initiating connections to unity,
    or when the Unity side is closed suddenly.
    
    Dev Logs:
    
    Originally wanted to separate the TCP code from the main.py, like what I have done in Unity.
    
    However, since the python side is only for sending detected data to Unity.
    No receiving function is required, nor multi-threading is needed.
    
    Also, I want to keep the existing videos useful so that I don't have to film them again.
    
    But I am planning to film stuffs about the UI and the saving system.
    
    There should be no further changes as both the detection part, other functionalities such as saving perferences, adjusting TCP port,
    and the UI is completed and at least in decent quality,
    
    except adding comments and bug fixes.
    mmmmmm44 committed May 14, 2022
    Configuration menu
    Copy the full SHA
    54a6645 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. Amend comments in main.py

    mmmmmm44 committed May 15, 2022
    Configuration menu
    Copy the full SHA
    03c3677 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Readded the updated unity packages of both unity chan project and Liv…

    …e2D Hiyori project.
    
    Updates of Unity side
    
    1. Separated the TCP related function from the controller script of both characters.
    
    Although it makes previous tutorials depreciated, it allows user to open multiple instances of the Unity project, which each of them can have a different model.
    
    Moreover, it gives control to the user when to start and stop the TCP server in Unity.
    
    2. Completed UI system in Unity.
    
    Two panels are added to the Unity application.
    
    First is the character control panel. It controls how the model responses with the raw values sent from python, like the threshold of blinking and mouth movement. User can also save the values which will be loaded automatically when he/she opens the application again.
    
    Second is the TCP server panel. Two buttons are provided to start and stop the Unity server at any time. Also, a text edit component is provided to allow user to input the port at their own wish. The range of the port value can be customized in the TCPServer.cs script. The custom port feature allows multiple instances of the application can be run and connected with their own instance of python main.py session.
    
    The UI panel will automatically resize thanks to the AdjustGridLayoutCellSize.cs script.
    
    3. Application aspect ratio adjustment.
    
    The aspect ratio is adjusted to 9:16 portrait mode to show the full body of the models, instead of just showing the upper body of the model.
    
    These changes can be experienced when importing the packages in UnityAssets/Packages/
    
    The size of each packages are less than 100 MB, which should raise no problem with the git lfs and cloning the project to the local.
    mmmmmm44 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    23f314c View commit details
    Browse the repository at this point in the history
  2. Commented two lines of code in both Model Controller scripts of Unity

    Commented two lines of code in both Model Controller scripts of Unity side to be error-free when following the YT tutorial.
    
    The two lines of code are in format GameObject.FindWithTag("GameController").GetComponent<UISystem>().*();
    
    Suppose they will link the UI system to show the correct values and allow adjusting the thresholds during runtime.
    
    However, building the UI system is time-consuming. The simpliest way is to comment them.
    
    The program still can be run, but lose customizability during runtime. It can be fixed by importing the complete unity package file and study it.
    
    Update .gitignore to disable ignoring the .unitypackage files.
    
    Updated README.md for clearer option descriptions.
    mmmmmm44 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    96a6949 View commit details
    Browse the repository at this point in the history
  3. Update README and re-added correct unity package.

    Update the setup procedure for correctly displaying the UI.
    
    Added instruction in setting up a 9:16 portrait ratio display mode in Unity.
    
    Re-added the correct unity package for UnityChan.
    
    Update the README file under UnityAssets/ folder.
    mmmmmm44 committed May 16, 2022
    Configuration menu
    Copy the full SHA
    0c19f53 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Update README.md

    Added the link to the Github tutorial about how to change game aspect ratio to 9:16.
    mmmmmm44 authored May 17, 2022
    Configuration menu
    Copy the full SHA
    48d5cf8 View commit details
    Browse the repository at this point in the history
Loading