FilesExpand file tree

 main

/

IncorrectExceptOrder.ql

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

34 lines (30 loc) · 1.06 KB

 main

/

IncorrectExceptOrder.ql

Copy path

Top

File metadata and controls

• Code
• Blame

34 lines (30 loc) · 1.06 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

/**

* @name Unreachable 'except' block

* @description Handling general exceptions before specific exceptions means that the specific

* handlers are never executed.

* @kind problem

* @tags reliability

* maintainability

* external/cwe/cwe-561

* @problem.severity error

* @sub-severity low

* @precision very-high

* @id py/unreachable-except

*/

import python

predicate incorrect_except_order(ExceptStmt ex1, ClassValue cls1, ExceptStmt ex2, ClassValue cls2) {

exists(int i, int j, Try t |

ex1 = t.getHandler(i) and

ex2 = t.getHandler(j) and

i < j and

cls1 = except_class(ex1) and

cls2 = except_class(ex2) and

cls1 = cls2.getASuperType()

)

}

ClassValue except_class(ExceptStmt ex) { ex.getType().pointsTo(result) }

from ExceptStmt ex1, ClassValue cls1, ExceptStmt ex2, ClassValue cls2

where incorrect_except_order(ex1, cls1, ex2, cls2)

select ex2,

"Except block for $@ is unreachable; the more general $@ for $@ will always be executed in preference.",

cls2, cls2.getName(), ex1, "except block", cls1, cls1.getName()