Add support for git submodules · Issue #4688 · microsoft/vscode-pull-request-github · GitHub
Skip to content

Add support for git submodules #4688

Closed
Closed

Description

@pinuke

Currently my repository uses git submodules for continuous integration

This allows me to make contributions and patches to other libs/tools right from within my own repository.

It would be nice, if this extension would recognize submodules.

Activity

  1. pinuke commented on Mar 30, 2023

    @pinuke
    Author

    Proposed Method 1: Using git's internal files to accomplish this:

    Here is a starting point for figuring out how to handle submodules: .gitmodules vs .git/config

    • gives you the basics on how git handles submodules internally.
    • particularly, these 2 files define the path to the submodule and url to the git repository.

    according to this comment, .git/config takes precedence over .gitmodules
    this answer confirms that

  2. pinuke commented on Mar 30, 2023

    @pinuke
    Author

    Proposed Method 2: Using git commands

    This question details methods to list off the submodules using the git command instead of using git's internal files.

    This method iterates through the .gitmodules file.
    This method iterates through the .git/config file (I believe it does anyway - based on a skim of git's source code)

  3. changed the title [-]Add support for submodules[/-] [+]Add support for git submodules[/+] on Mar 30, 2023
  4. pp244 commented on Apr 13, 2023

    @pp244

    I would very much appreciate this feature. The really great addition "Copy GitHub deep links" yields invalid links when working in a repo with submodules 😒

  5. DFelten commented on Jul 20, 2023

    @DFelten

    We are working on several apps that use a shared framework. This is included as a submodule. Since we often work on both in parallel, we usually create a pull request for the app and the framework.

    It would be great if the extension could also handle pull requests for submodules.

  6. oleg-liatte commented on Aug 7, 2023

    @oleg-liatte

    There actually IS support of submodules, somewhat limited and probably unintended. See #5148 workaround.

    It seems that it could be enough to just sync to Source Control panel to "see" all checked out nested repos, including submodules.

  7. alexr00 commented on Dec 14, 2023

    @alexr00
    Member

    Submodules should work much better now. If you see specific issues with submodules, please file new issues and I will investigate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature-requestRequest for new features or functionality

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions