Activity

1. Erich Gamma (egamma)

   added

   plan-itemVS Code - planned item for upcomingVS Code - planned item for upcoming

   on May 3, 2021
2. Erich Gamma (egamma)

   added this to the May 2021 milestone on May 3, 2021
3. Erich Gamma (egamma)

   assigned

   Erich Gamma (egamma)

   and

   Sandeep Somavarapu (sandy081)

   on May 3, 2021
4. Erich Gamma (egamma)

   closed this as completedon May 3, 2021
5. rebornix commented on May 3, 2021

   

   Peng Lyu (rebornix)

   on May 3, 2021

   Last edited by rebornix

   Contributor

   More actions

   Martin Aeschlimann (@aeschli) from the release note that it seems we generated list by checking if an extension is using fs. Do you have an idea how this will impact Vim. Vim's desktop version uses fs but it can work with a virtual file (textDocument). Asking as the wiki link is not valid yet.
6. Erich Gamma (egamma)

   reopened this on May 4, 2021
7. egamma commented on May 4, 2021

   

   Erich Gamma (egamma)

   on May 4, 2021

   MemberAuthor

   More actions

   Peng Lyu (@rebornix) Martin Aeschlimann (@aeschli) has started to update the guide https://github.com/microsoft/vscode/wiki/Virtual-Workspaces and there is more info available.

   Just to share what I've found when I did the initial checking of the Vim extension. I found that it works OK, but I haven't tested all the features of Vim. From reviewing the code the extension already abstracts fs access in src/platform/node/fs.ts and uses vscode.workspace.fs where possible 👍 . However, vscode.workspace.fs is not used everywhere and it would be good investigate the impact of this in a virtual workspace setup and to handle it gracefully. For example, unlink is using fs directly.
8. Erich Gamma (egamma)

   assigned

   Martin Aeschlimann (aeschli)

   and unassigned

   Erich Gamma (egamma)

   and

   Sandeep Somavarapu (sandy081)

   on May 10, 2021
9. Martin Aeschlimann (aeschli)

   changed the title [-]Track the adoption of the `virtualWorkspaces` property[/-] [+]Manage special defaults of the `virtualWorkspaces` property[/+] on May 10, 2021
10. cyrilletuzi commented on May 12, 2021

    

    Cyrille Tuzi (cyrilletuzi)

    on May 12, 2021

    Last edited by cyrilletuzi

    More actions

    My Angular Schematics extension is doing a lot of files/paths management, and trying to comply with the virtual workspaces guide (PR cyrilletuzi/vscode-angular-schematics#551) revealed many things (being forced to use Node APIs because of missing methods on vscode.Uri, being forced to use fsPath in some place because of an issue with path in some scenarios, etc.). Where should I report these things?
11. aeschli commented on May 14, 2021

    

    Martin Aeschlimann (aeschli)

    on May 14, 2021

    Last edited by aeschli

    Contributor

    More actions

    Cyrille Tuzi (@cyrilletuzi) You can find path like utilities in the vscode-uri node module:
    See https://www.npmjs.com/package/vscode-uri, section Usage: Util

    👍React with 👍1Reacted by Cyrille Tuzi
12. cyrilletuzi commented on May 25, 2021

    

    Cyrille Tuzi (cyrilletuzi)

    on May 25, 2021

    More actions

    Martin Aeschlimann (@aeschli) Thanks, vscode-uri solved some of my issues.

    1. Is there a reason some methods (like joinPath()) are directly available in @types/vscode while some others (like dirname() and basename()) require vscode-uri? Now that you explicitly require to not use Node APIs directly, it would make sense to include everything directly in @types/vscode.

    Also, there is still some issues and missing features so I'm able to get rid of all Node APIs:

    2. I need path.relative() a lot, and it doesn't exist in vscode-uri. Can it be added? It would work the same (2 Uris as params, and returns a string representing the relative path).

    3. contextUri.path wrongly uppercased on Windows #116298, which was not taken into account properly, should be reopened and fixed (otherwise I'm forced to use .fsPath in some places, as .path is buggy in some scenarios explained in the issue).

    4. vscode.workspace.createFileSystemWatcher() only accepts a fsPath string, and not a Uri as all other VS Code APIs. Do you confirm it's intended and it can't be done with schemes other than file, and thus that extensions require a manual check (if (uri.scheme === 'file'))?
13. Martin Aeschlimann (aeschli)

    modified the milestones: May 2021, June 2021 on May 31, 2021
14. Martin Aeschlimann (aeschli)

    modified the milestones: June 2021, July 2021 on Jun 29, 2021
15. Martin Aeschlimann (aeschli)

    modified the milestones: July 2021, August 2021 on Jul 25, 2021
16. Martin Aeschlimann (aeschli)

    modified the milestones: August 2021, September 2021 on Aug 24, 2021
17. aeschli commented on Sep 15, 2021

    

    Martin Aeschlimann (aeschli)

    on Sep 15, 2021

    Contributor

    More actions

    Only one more adoption since July. My guess is that given we provide the default, the listed extensions don't have any pressure to adopt.

    I'll close this issue now and will make changes to our default on request.

    😄React with 😄1Reacted by Lemmingh
18. Martin Aeschlimann (aeschli)

    closed this as completedon Sep 16, 2021
19. github-actions

    locked and limited conversation to collaborators on Oct 31, 2021