{{ message }}
Repository navigation
Terminal: move workbench dependencies into electron-sandbox #117257
Description
Now that the terminals are managed from the shared process it would be great if this dependency here:
vscode/src/vs/workbench/workbench.desktop.main.ts
Lines 133 to 134 in 79a623d
Could fully move into electron-sandbox (into src/vs/workbench/workbench.sandbox.main.ts) so that we can even test it from running scripts/code.sh --__sandbox
Activity
[-]Terminal: move dependencies into electron-sandbox[/-][+]Terminal: move workbench dependencies into electron-sandbox[/+]bpasero commentedon Feb 22, 2021
It looks like we have a terminal contribution already in sandbox:
vscode/src/vs/workbench/workbench.sandbox.main.ts
Line 117 in a9536c3
But I guess those are just a few pieces of it.
Tyriar commentedon Feb 22, 2021
Had this in mind for March already, closing #116463 off in favor of this.
bpasero commentedon Feb 25, 2021
Slightly related, we seem to still have a native module dependency
windows-process-treein renderer that then also should move.bpasero commentedon Mar 5, 2021
Daniel Imms (@Tyriar) just noticed this
externalTerminalcontrib too:vscode/src/vs/workbench/workbench.desktop.main.ts
Line 136 in c41922b
Is that a separate issue to look at?
Tyriar commentedon Mar 5, 2021
Yes let's track that separately
Remove unneeded impl from browser/terminalInstanceService
Move terminalRemote and parts of native contribution to sandbox
Move getParentEnvironment into pty service
Remove inheritEnv, don't use shell env
bpasero commentedon May 4, 2021
👏