Fix issue #244138: Disable button shows dropdown when it should show 'Disable (Workspace)' button

realMelTuc · realMelTuc · commit c32542a46190 · 2026-02-19T20:07:43.000-05:00
When an extension is disabled globally and then enabled for a workspace,
the Disable button should show 'Disable (Workspace)' without a dropdown,
not a dropdown with both 'Disable' and 'Disable (Workspace)' options.

The fix modifies DisableGloballyAction.update() to only enable the action
when the extension is currently enabled globally, not when it's enabled
for workspace only. This prevents showing the global disable option when
it's not applicable.
diff --git a/src/vs/workbench/contrib/extensions/browser/extensionsActions.ts b/src/vs/workbench/contrib/extensions/browser/extensionsActions.ts
@@ -1751,7 +1751,7 @@ export class DisableGloballyAction extends ExtensionAction {
 		this.enabled = false;
 		if (this.extension && this.extension.local && !this.extension.isWorkspaceScoped && this.extensionService.extensions.some(e => areSameExtensions({ id: e.identifier.value, uuid: e.uuid }, this.extension!.identifier))) {
 			this.enabled = this.extension.state === ExtensionState.Installed
-				&& (this.extension.enablementState === EnablementState.EnabledGlobally || this.extension.enablementState === EnablementState.EnabledWorkspace)
+				&& this.extension.enablementState === EnablementState.EnabledGlobally
 				&& this.extensionEnablementService.canChangeEnablement(this.extension.local);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -1751,7 +1751,7 @@ export class DisableGloballyAction extends ExtensionAction {`
`1751`	`1751`	`this.enabled = false;`
`1752`	`1752`	`if (this.extension && this.extension.local && !this.extension.isWorkspaceScoped && this.extensionService.extensions.some(e => areSameExtensions({ id: e.identifier.value, uuid: e.uuid }, this.extension!.identifier))) {`
`1753`	`1753`	`this.enabled = this.extension.state === ExtensionState.Installed`
`1754`		`- && (this.extension.enablementState === EnablementState.EnabledGlobally \|\| this.extension.enablementState === EnablementState.EnabledWorkspace)`
	`1754`	`+ && this.extension.enablementState === EnablementState.EnabledGlobally`
`1755`	`1755`	`&& this.extensionEnablementService.canChangeEnablement(this.extension.local);`
`1756`	`1756`	`}`
`1757`	`1757`	`}`