You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Clarify reasoning behind environment variables in README.md #3
The "environmentVariables" member in the json file seems to be only partially implemented, though the readme file suggests it is "done" ... will this receive more development?
What I thought it did was test for a given environment variable to have the
given value, but that does not seem to work...
Am I misunderstanding how it is intended to function?
Thank you!
To be clearer, I thought that Test-FeatureFlag would take the environment variable items into account when returning True/False... my testing and rereading the code show that doesn't and can't happen with the current code.
The documentation is definitely unclear on that.
The goal of the environment variables support is the opposite: when some feature flags are enabled, you can create an environment configuration file with the Out-FeaturesEnvConfig cmdlet, containing only the environment variable definition matching the enabled feature flags.
The goal of this feature is to add easy feature flag support to batch scripts that cannot easily directly invoke Test-FeatureFlag, but can easily depend on environment variables.
On Sun, Apr 30, 2023 at 4:24 AM Andrea Spadaccini ***@***.***> wrote:
The documentation is definitely unclear on that.
The goal of the environment variables support is the opposite: when some
feature flags are enabled, you can create an environment configuration file
with the Out-FeaturesEnvConfig cmdlet, containing only the environment
variable definition matching the enabled feature flags.
The goal of this feature is to add easy feature flag support to batch
scripts that cannot easily directly invoke Test-FeatureFlag, but can
easily depend on environment variables.
Hope this makes things clearer!
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYXVGTUHPQTDHFSVMX7CBDLXDYVWNANCNFSM4HQRSVCA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
Activity
tomrowton-alk commentedon Apr 27, 2023
The "environmentVariables" member in the json file seems to be only partially implemented, though the readme file suggests it is "done" ... will this receive more development?
lupino3 commentedon Apr 28, 2023
Hi tomrowton-alk, the feature is implemented but not very well documented.
We do use it in production.
Is there something that you are missing from this feature?
Thanks!
tomrowton-alk commentedon Apr 28, 2023
tomrowton-alk commentedon Apr 28, 2023
To be clearer, I thought that
Test-FeatureFlagwould take the environment variable items into account when returning True/False... my testing and rereading the code show that doesn't and can't happen with the current code.lupino3 commentedon Apr 30, 2023
The documentation is definitely unclear on that.
The goal of the environment variables support is the opposite: when some feature flags are enabled, you can create an environment configuration file with the
Out-FeaturesEnvConfigcmdlet, containing only the environment variable definition matching the enabled feature flags.The goal of this feature is to add easy feature flag support to batch scripts that cannot easily directly invoke
Test-FeatureFlag, but can easily depend on environment variables.Hope this makes things clearer!
tomrowton-alk commentedon May 2, 2023
lupino3 commentedon May 2, 2023
Happy to help! And this discussion to me really means that we need to update the docs ASAP. Thanks for your questions!