{{ message }}
Conversation
Signed-off-by: Phil Howard <github@gadgetoid.com>
pico-sdk 2.3.1 reverted default_text_excludes.incl to pre-2.3.0 behaviour, leaving libc.a and the newlib mem* objects in flash. The rp2 override keeps them in SRAM; note that this is now a deliberate divergence. Signed-off-by: Phil Howard <github@gadgetoid.com>
pico-sdk 2.3.1 narrowed its default_rodata_excludes.incl to libgcc and libm only, which would move libc.a and newlib mem* .rodata back to flash. Signed-off-by: Phil Howard <github@gadgetoid.com>
|
Code size report: |
Contributor
Author
|
Will have to poke that rp2 size difference and see if any of it is linker script wobbles versus the code refactor. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Bump Pico SDK to v2.3.1 - https://github.com/raspberrypi/pico-sdk/releases/tag/2.3.1
Testing
TBC
Trade-offs and Alternatives
Pico SDK's "bugfix" to linker scripts was walked back in raspberrypi/pico-sdk#3075 and our downstream divergences still preserve the SDK 2.3.0 behaviour. May require some consideration around deferring to upstream.
This bump also sets
-mstrict-alignon RISCV builds, so there may be a size difference.Bugfixes may plausibly affect the following issues, but this is as of yet untested:
time.sleepwaking early, Pico 2 Wntptime.settime()breaks sleep timing under_threadGenerative AI
I used generative AI tools when creating this PR, but a human has checked the
code and is responsible for the code and the description above.