{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 2
Expand file tree
/
Copy pathtest_download.cpp
More file actions
255 lines (214 loc) · 8.74 KB
/
Copy pathtest_download.cpp
File metadata and controls
255 lines (214 loc) · 8.74 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
// Live tests against a real HTTPS endpoint (httpbin.org).
//
// The framing parsers and the response contracts these used to also cover moved
// to `test_framing.cpp`, and the connection-pool behaviour to `test_pool.cpp`,
// which scripts its own server. What is left here is the part that genuinely
// needs the internet: a real certificate chain, a real chunked stream, a real
// redirect.
#include <gtest/gtest.h>
import mcpplibs.tinyhttps;
import std;
namespace https = mcpplibs::tinyhttps;
// Test that a failed streaming request carries its error body, against a real
// HTTPS endpoint. httpbin's /status/418 answers non-2xx with a body, which is
// exactly the shape SseParser cannot turn into events.
class StreamErrorBodyLiveTest : public ::testing::Test {
protected:
void SetUp() override { https::Socket::platform_init(); }
};
// ON THE LIBRARY'S OWN DEFAULTS, AND THE READ TIMEOUT IS PART OF THE
// OBSERVATION RATHER THAN A SAFETY NET.
//
// The first form of this test set `keepAlive = false`, "so the server closes
// and the read loop ends". That comment was the defect: `send_stream` had no
// branch for a declared `Content-Length`, so a response that was not chunked
// was read until the connection closed — and on the defaults the server does
// not close. The body arrived, one full `readTimeoutMs` late.
//
// keepAlive = false status=418 body=135 elapsed 1370 ms
// keepAlive = true status=418 body=135 elapsed 9379 ms (timeout 8000)
//
// So the configuration under test is the default one, and the elapsed time is
// asserted. A test that closed the connection to make the loop end would be
// examining the one arrangement in which the defect does not appear.
TEST_F(StreamErrorBodyLiveTest, FailedStreamKeepsTheErrorBody) {
https::HttpClientConfig cfg;
cfg.connectTimeoutMs = 15000;
cfg.readTimeoutMs = 30000;
// keepAlive is left at its default, which is true.
https::HttpClient client(cfg);
https::HttpRequest req;
req.method = https::Method::GET;
req.url = "https://httpbin.org/status/418";
int events = 0;
const auto started = std::chrono::steady_clock::now();
auto res = client.send_stream(req, [&](const https::SseEvent&) {
++events;
return true;
});
const auto elapsed = std::chrono::duration_cast<std::chrono::milliseconds>(
std::chrono::steady_clock::now() - started).count();
EXPECT_EQ(res.statusCode, 418);
EXPECT_EQ(events, 0) << "an error document is not an event stream";
EXPECT_FALSE(res.body.empty()) << "error body was dropped";
EXPECT_NE(res.body.find("teapot"), std::string::npos);
// Generous against a slow runner and still an order of magnitude below the
// read timeout, which is what the defect consumed.
EXPECT_LT(elapsed, 15000)
<< "the body arrived after " << elapsed
<< " ms; a declared Content-Length was not honoured and the reader "
"waited for a close that keep-alive was never going to bring";
}
// The success path, on the framing an event stream actually uses. A 2xx is not
// captured, so `body` stays empty and the bytes reach the parser — and it must
// still return promptly, since the chunked branch is the one this change did
// not restructure.
TEST_F(StreamErrorBodyLiveTest, AChunkedSuccessIsUnchangedAndPrompt) {
https::HttpClientConfig cfg;
cfg.connectTimeoutMs = 15000;
cfg.readTimeoutMs = 30000;
https::HttpClient client(cfg);
https::HttpRequest req;
req.method = https::Method::GET;
req.url = "https://httpbin.org/stream/3";
const auto started = std::chrono::steady_clock::now();
auto res = client.send_stream(req, [](const https::SseEvent&) { return true; });
const auto elapsed = std::chrono::duration_cast<std::chrono::milliseconds>(
std::chrono::steady_clock::now() - started).count();
EXPECT_EQ(res.statusCode, 200);
EXPECT_TRUE(res.body.empty()) << "a 2xx body is not captured; it is the caller's stream";
EXPECT_LT(elapsed, 15000) << "the chunked reader did not terminate promptly";
}
// Test download_to_file against a real HTTPS endpoint.
// Uses httpbin.org which returns known-size responses.
class DownloadToFileTest : public ::testing::Test {
protected:
std::filesystem::path tmpDir;
void SetUp() override {
https::Socket::platform_init();
tmpDir = std::filesystem::temp_directory_path() / "tinyhttps_test";
std::filesystem::create_directories(tmpDir);
}
void TearDown() override {
std::error_code ec;
std::filesystem::remove_all(tmpDir, ec);
}
};
TEST_F(DownloadToFileTest, BasicDownloadWithProgress) {
https::HttpClientConfig cfg;
cfg.connectTimeoutMs = 15000;
cfg.readTimeoutMs = 30000;
cfg.keepAlive = false;
https::HttpClient client(cfg);
auto dest = tmpDir / "test_100bytes.bin";
std::int64_t lastTotal = -1;
std::int64_t lastDownloaded = -1;
int callCount = 0;
auto result = client.download_to_file(
"https://httpbin.org/bytes/100",
dest,
[&](std::int64_t total, std::int64_t downloaded) {
lastTotal = total;
lastDownloaded = downloaded;
++callCount;
}
);
ASSERT_TRUE(result.ok()) << "Error: " << result.error;
EXPECT_EQ(result.statusCode, 200);
EXPECT_EQ(result.bytesWritten, 100);
EXPECT_TRUE(std::filesystem::exists(dest));
EXPECT_EQ(std::filesystem::file_size(dest), 100u);
EXPECT_GT(callCount, 0) << "Progress callback should be called at least once";
EXPECT_EQ(lastDownloaded, 100);
EXPECT_EQ(lastTotal, 100);
}
TEST_F(DownloadToFileTest, ProgressIncrementsMonotonically) {
https::HttpClientConfig cfg;
cfg.connectTimeoutMs = 15000;
cfg.readTimeoutMs = 60000;
cfg.keepAlive = false;
https::HttpClient client(cfg);
auto dest = tmpDir / "test_50k.bin";
std::vector<std::int64_t> downloadedValues;
auto result = client.download_to_file(
"https://httpbin.org/bytes/51200",
dest,
[&](std::int64_t total, std::int64_t downloaded) {
(void)total;
downloadedValues.push_back(downloaded);
}
);
ASSERT_TRUE(result.ok()) << "Error: " << result.error;
EXPECT_EQ(result.bytesWritten, 51200);
// Progress must be monotonically increasing
for (std::size_t i = 1; i < downloadedValues.size(); ++i) {
EXPECT_GT(downloadedValues[i], downloadedValues[i - 1])
<< "Progress not monotonic at index " << i;
}
// Must have multiple progress calls for 50KB
EXPECT_GT(downloadedValues.size(), 1u)
<< "50KB download should report progress more than once";
}
TEST_F(DownloadToFileTest, FollowsRedirects) {
https::HttpClientConfig cfg;
cfg.connectTimeoutMs = 15000;
cfg.readTimeoutMs = 30000;
cfg.keepAlive = false;
https::HttpClient client(cfg);
auto dest = tmpDir / "redirected.bin";
// httpbin /redirect-to redirects to the given URL
auto result = client.download_to_file(
"https://httpbin.org/redirect-to?url=https%3A%2F%2Fhttpbin.org%2Fbytes%2F50",
dest
);
ASSERT_TRUE(result.ok()) << "Error: " << result.error;
EXPECT_EQ(result.bytesWritten, 50);
EXPECT_TRUE(std::filesystem::exists(dest));
}
TEST_F(DownloadToFileTest, NoProgressCallbackStillWorks) {
https::HttpClientConfig cfg;
cfg.connectTimeoutMs = 15000;
cfg.readTimeoutMs = 30000;
cfg.keepAlive = false;
https::HttpClient client(cfg);
auto dest = tmpDir / "no_progress.bin";
auto result = client.download_to_file(
"https://httpbin.org/bytes/200",
dest
);
ASSERT_TRUE(result.ok()) << "Error: " << result.error;
EXPECT_EQ(result.bytesWritten, 200);
}
TEST_F(DownloadToFileTest, Http404ReturnsError) {
https::HttpClientConfig cfg;
cfg.connectTimeoutMs = 15000;
cfg.readTimeoutMs = 30000;
cfg.keepAlive = false;
https::HttpClient client(cfg);
auto dest = tmpDir / "not_found.bin";
auto result = client.download_to_file(
"https://httpbin.org/status/404",
dest
);
EXPECT_FALSE(result.ok());
EXPECT_EQ(result.statusCode, 404);
}
TEST_F(DownloadToFileTest, TotalBytesKnownForContentLength) {
https::HttpClientConfig cfg;
cfg.connectTimeoutMs = 15000;
cfg.readTimeoutMs = 30000;
cfg.keepAlive = false;
https::HttpClient client(cfg);
auto dest = tmpDir / "known_size.bin";
std::int64_t reportedTotal = -1;
auto result = client.download_to_file(
"https://httpbin.org/bytes/1024",
dest,
[&](std::int64_t total, [[maybe_unused]] std::int64_t downloaded) {
if (reportedTotal < 0) reportedTotal = total;
}
);
ASSERT_TRUE(result.ok()) << "Error: " << result.error;
// httpbin /bytes/N returns Content-Length: N
EXPECT_EQ(reportedTotal, 1024);
}
You can’t perform that action at this time.