{{ message }}
Commit 3d758e2
committed
Don't set savefig.facecolor/edgecolor in dark_background/538 styles.
Previously, the dark_background and fivethirtyeight styles would set the
savefig.facecolor and savefig.edgecolor rcParams to the same values as
figure.facecolor and figure.edgecolor; i.e., if a user uses a style but
tweaks the figure facecolor, this tweak is lost (overridden) when saving
the figure. A concrete example would be using the dark_background style
but wanting a dark gray background instead of a black one, e.g.
`mpl.style.use(["dark_background", {"figure.facecolor": ".2"}]); plot();
savefig(...)`.
In all likelihood these values were set because the styles
predate the ability to set these savefig rcParams to "auto", which means
"don't change the figure facecolor, just use it as is" (a feature
introduced exactly because this auto-switching of color by savefig was
confusing users). Now we can just remove these rcParams from the two
styles (which are the only ones affected by the issue -- the grayscale
style also sets savefig.facecolor but to a value different from
figure.facecolor) and let them inherit the global default value, "auto".1 parent cebc4d8 commit 3d758e2
3 files changed
Lines changed: 13 additions & 7 deletions
File tree
- doc/api/next_api_changes/behavior
- lib/matplotlib/mpl-data/stylelib
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | 21 | | |
25 | 22 | | |
26 | 23 | | |
| |||
0 commit comments