Fix set_size_inches on HiDPI screens · matplotlib/matplotlib@38691d7 · GitHub
Skip to content

Commit 38691d7

Browse files
QuLogicQuLogic
committed
Fix set_size_inches on HiDPI screens
This passes physical pixels to the backend, as it will be more accurate due to the int-cast. Fixes #21090
1 parent ef74de4 commit 38691d7

5 files changed

Lines changed: 12 additions & 7 deletions

File tree

‎lib/matplotlib/backend_bases.py‎

Lines changed: 1 addition & 1 deletion

‎lib/matplotlib/backends/backend_gtk3.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -421,6 +421,8 @@ def set_window_title(self, title):
421421

422422
def resize(self, width, height):
423423
"""Set the canvas size in pixels."""
424+
width = int(width / self.canvas.device_pixel_ratio)
425+
height = int(height / self.canvas.device_pixel_ratio)
424426
if self.toolbar:
425427
toolbar_size = self.toolbar.size_request()
426428
height += toolbar_size.height

‎lib/matplotlib/backends/backend_gtk4.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,8 @@ def set_window_title(self, title):
372372

373373
def resize(self, width, height):
374374
"""Set the canvas size in pixels."""
375+
width = int(width / self.canvas.device_pixel_ratio)
376+
height = int(height / self.canvas.device_pixel_ratio)
375377
if self.toolbar:
376378
min_size, nat_size = self.toolbar.get_preferred_size()
377379
height += nat_size.height

‎lib/matplotlib/backends/backend_qt.py‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -587,12 +587,14 @@ def _get_toolbar(self, canvas, parent):
587587
return toolbar
588588

589589
def resize(self, width, height):
590-
# these are Qt methods so they return sizes in 'virtual' pixels
591-
# so we do not need to worry about dpi scaling here.
590+
# The Qt methods return sizes in 'virtual' pixels so we do need to
591+
# rescale from physical to logical pixels.
592+
width = int(width / self.canvas.device_pixel_ratio)
593+
height = int(height / self.canvas.device_pixel_ratio)
592594
extra_width = self.window.width() - self.canvas.width()
593595
extra_height = self.window.height() - self.canvas.height()
594-
self.canvas.resize(width, height)
595-
self.window.resize(width + extra_width, height + extra_height)
596+
self.canvas.resize(round(width), round(height))
597+
self.window.resize(round(width + extra_width), round(height + extra_height))
596598

597599
def show(self):
598600
self.window.show()

‎lib/matplotlib/figure.py‎

Lines changed: 1 addition & 2 deletions

0 commit comments

Comments
 (0)