Replace reflection with X-HTTP-Method-Override · mamh-java/java-github-api@8e20f4d · GitHub
Skip to content

Commit 8e20f4d

Browse files
bitwisemanbitwiseman
committed
Replace reflection with X-HTTP-Method-Override
Fixes hub4j#754
1 parent 7c8a7ff commit 8e20f4d

104 files changed

Lines changed: 623 additions & 393 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/main/java/org/kohsuke/github/GitHubHttpUrlConnectionClient.java‎

Lines changed: 2 additions & 24 deletions

‎src/test/java/org/kohsuke/github/junit/GitHubWireMockRule.java‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,9 @@ private void recordSnapshot(WireMockServer server, String target, boolean isRawS
159159
if (server != null) {
160160

161161
server.snapshotRecord(recordSpec().forTarget(target)
162+
// "X-HTTP-Method-Override" is used to send http methods not supported by
163+
// HttpURLConnection without using hacky Java reflection techniques
164+
.captureHeader("X-HTTP-Method-Override")
162165
// "If-None-Match" header used for ETag matching for caching connections
163166
.captureHeader("If-None-Match")
164167
// "If-Modified-Since" header used for ETag matching for caching connections

‎src/test/resources/org/kohsuke/github/AppTest/wiremock/notifications/mappings/notifications_threads_523050578-25.json‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,18 @@
33
"name": "notifications_threads_523050578",
44
"request": {
55
"url": "/notifications/threads/523050578",
6-
"method": "PATCH",
76
"bodyPatterns": [
87
{
98
"equalToJson": "{}",
109
"ignoreArrayOrder": true,
1110
"ignoreExtraElements": true
1211
}
1312
],
13+
"method": "POST",
1414
"headers": {
15+
"X-HTTP-Method-Override": {
16+
"equalTo": "PATCH"
17+
},
1518
"Accept": {
1619
"equalTo": "text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2"
1720
}

‎src/test/resources/org/kohsuke/github/AppTest/wiremock/testCreateCommitComment/mappings/repos_kohsuke_sandbox-ant_comments_46267761-7.json‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@
33
"name": "repos_kohsuke_sandbox-ant_comments_46267761",
44
"request": {
55
"url": "/repos/kohsuke/sandbox-ant/comments/46267761",
6-
"method": "PATCH",
6+
"method": "POST",
77
"headers": {
8+
"X-HTTP-Method-Override": {
9+
"equalTo": "PATCH"
10+
},
811
"Accept": {
912
"equalTo": "text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2"
1013
}

‎src/test/resources/org/kohsuke/github/AppTest/wiremock/testCreateIssue/mappings/repos_hub4j-test-org_github-api-test_issues_1-11.json‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,18 @@
33
"name": "repos_hub4j-test-org_github-api-test_issues_1",
44
"request": {
55
"url": "/repos/hub4j-test-org/github-api-test/issues/1",
6-
"method": "PATCH",
76
"bodyPatterns": [
87
{
98
"equalToJson": "{\"state\":\"closed\"}",
109
"ignoreArrayOrder": true,
1110
"ignoreExtraElements": true
1211
}
1312
],
13+
"method": "POST",
1414
"headers": {
15+
"X-HTTP-Method-Override": {
16+
"equalTo": "PATCH"
17+
},
1518
"Accept": {
1619
"equalTo": "text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2"
1720
}

‎src/test/resources/org/kohsuke/github/AppTest/wiremock/testRepoCRUD/mappings/repos_bitwiseman_github-api-test-rename-3.json‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@
33
"name": "repos_bitwiseman_github-api-test-rename",
44
"request": {
55
"url": "/repos/bitwiseman/github-api-test-rename",
6-
"method": "PATCH",
6+
"method": "POST",
77
"headers": {
8+
"X-HTTP-Method-Override": {
9+
"equalTo": "PATCH"
10+
},
811
"Accept": {
912
"equalTo": "text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2"
1013
}

‎src/test/resources/org/kohsuke/github/AppTest/wiremock/testRepoCRUD/mappings/repos_bitwiseman_github-api-test-rename-4.json‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@
33
"name": "repos_bitwiseman_github-api-test-rename",
44
"request": {
55
"url": "/repos/bitwiseman/github-api-test-rename",
6-
"method": "PATCH",
6+
"method": "POST",
77
"headers": {
8+
"X-HTTP-Method-Override": {
9+
"equalTo": "PATCH"
10+
},
811
"Accept": {
912
"equalTo": "text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2"
1013
}

‎src/test/resources/org/kohsuke/github/AppTest/wiremock/testRepoCRUD/mappings/repos_bitwiseman_github-api-test-rename-5.json‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@
33
"name": "repos_bitwiseman_github-api-test-rename",
44
"request": {
55
"url": "/repos/bitwiseman/github-api-test-rename",
6-
"method": "PATCH",
6+
"method": "POST",
77
"headers": {
8+
"X-HTTP-Method-Override": {
9+
"equalTo": "PATCH"
10+
},
811
"Accept": {
912
"equalTo": "text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2"
1013
}

‎src/test/resources/org/kohsuke/github/AppTest/wiremock/testRepoCRUD/mappings/repos_bitwiseman_github-api-test-rename-6.json‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@
33
"name": "repos_bitwiseman_github-api-test-rename",
44
"request": {
55
"url": "/repos/bitwiseman/github-api-test-rename",
6-
"method": "PATCH",
6+
"method": "POST",
77
"headers": {
8+
"X-HTTP-Method-Override": {
9+
"equalTo": "PATCH"
10+
},
811
"Accept": {
912
"equalTo": "text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2"
1013
}

‎src/test/resources/org/kohsuke/github/AppTest/wiremock/testRepoCRUD/mappings/repos_bitwiseman_github-api-test-rename-7.json‎

Lines changed: 4 additions & 1 deletion

0 commit comments

Comments
 (0)