Comparing master...features/mage-errors · mage/mage · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mage/mage
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: mage/mage
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: features/mage-errors
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 7 files changed
  • 1 contributor

Commits on Dec 11, 2017

  1. MageError class 

    Standard MageError class for user-land.

This should help:

  1. Standardize error management
  2. Allow for throwing errors (and interrupt the execution flow)
     without necessarily logging an error
  3. Allow to attach additional details to the error to be logged, thus
     removing the need for an additional log call prior to throwing
  4. Attach a response code to be sent to the client; this also has the
     advantage of being part of the log data, thus making it easier
     to search for error occurences by code instead of by message
     content.

Fixes #135
    @stelcheck
    stelcheck committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    2d8009c View commit details
    Browse the repository at this point in the history
Loading