dev-agent/.github/pull_request_template.md at main · lytics/dev-agent · GitHub
Skip to content

Latest commit

 

History

History
78 lines (53 loc) · 1.92 KB

File metadata and controls

78 lines (53 loc) · 1.92 KB

📋 Description

🔗 Related Issues

Closes #

🧪 Code Standards Checklist

  • Pure functions extracted to utils/ modules
  • Utilities achieve 100% coverage (statements & functions)
  • No type assertions (as, !) without validation
  • Runtime validation for external data (Zod/type guards)
  • Result types used instead of exceptions
  • Modules organized by domain (not generic "utils")
  • Each module < 300 lines, each class < 400 lines
  • Constructor injection for dependencies
  • Atomic commits with clear dependencies

See: TypeScript Standards

✅ Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Coverage meets targets:
    • Pure utilities: 100%
    • Integration: >80%
    • CLI/UI: >60%
  • All tests passing locally

📊 Coverage

Before: X% statements, Y% branches, Z% functions
After:  X% statements, Y% branches, Z% functions

🏗️ Architecture

  • Follows dependency order (foundation → dependent → integration)
  • Barrel exports for clean imports
  • Clear separation of pure/impure code

📝 Documentation

  • Updated README if public API changed
  • Added JSDoc for public functions
  • Updated CHANGELOG (if applicable)

🚀 Deployment

  • No breaking changes
  • Backward compatible
  • Database migrations (if applicable)

📸 Screenshots


Commit Strategy:

  • Atomic commits (each builds independently)
  • Conventional commit messages
  • Clear commit descriptions