feat(publish): replace +{SHA} with .{SHA} in lerna publish --canary by MatusKnizka · Pull Request #4124 · lerna/lerna · GitHub
Skip to content

feat(publish): replace +{SHA} with .{SHA} in lerna publish --canary#4124

Draft
MatusKnizka wants to merge 2 commits into
lerna:mainfrom
MatusKnizka:feature/dot-instead-of-plus
Draft

feat(publish): replace +{SHA} with .{SHA} in lerna publish --canary#4124
MatusKnizka wants to merge 2 commits into
lerna:mainfrom
MatusKnizka:feature/dot-instead-of-plus

Conversation

@MatusKnizka

@MatusKnizka MatusKnizka commented Nov 15, 2024

Copy link
Copy Markdown

Replace +{SHA} with .{SHA} in lerna publish --canary

Description

Instead of using plus (+) sign in package name provided by --canary flag, use dot.

Motivation and Context

It's not possible to publish --canary version into jfrog artifactory, as jfrog is cutting part of filename, due to + (plus) character. So, instead of using +, I would suggest to use dot.

#2060

How Has This Been Tested?

Unit tests
Integration tests
Run publish command

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nx-cloud

nx-cloud Bot commented Feb 19, 2025

Copy link
Copy Markdown

@JamesHenry

Copy link
Copy Markdown
Member

@JamesHenry JamesHenry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@JamesHenry JamesHenry marked this pull request as draft September 15, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants