#45355 - Remove filmstrip_image download test (shotgunsoftware#156)

bolducl · web-flow · commit 4809efc6bb46 · 2017-11-10T15:32:24.000-05:00
Originally, there was a bug and the filmstrip_image url returned was bogus but it was a signed url which returned 200 and image/jpeg.
This was fixed and now, in NFS mode only, filmstrip_image returns a valid redirect url on the filmstrip_image.
That url isn't a signed url and requires login credential so we now use sg.download_attachment to download it and we validate status differently.
Note that this is not an issue in s3 mode since the filmstrip_image s3 url is returned.
diff --git a/tests/test_api.py b/tests/test_api.py
@@ -257,10 +257,11 @@ def test_upload_thumbnail_in_create(self):
         self.assertEqual(new_version.get('project'), self.project)
         self.assertTrue(new_version.get('filmstrip_image') is not None)
 
-        h = Http(".cache")
-        filmstrip_thumb_resp, content = h.request(new_version.get('filmstrip_image'), "GET")
-        self.assertEqual(filmstrip_thumb_resp['status'], '200')
-        self.assertEqual(filmstrip_thumb_resp['content-type'], 'image/jpeg')
+        url = new_version.get('filmstrip_image')
+        data = self.sg.download_attachment({'url': url})
+        self.assertTrue(isinstance(data, str))
+        # check that the credential did work and that we don't have the login page
+        self.assertFalse('login' in data.lower())
 
         self.sg.delete("Version", new_version['id'])
     # end test_upload_thumbnail_in_create
