Set Bug.weburl that is compatible with the REST API (fixes python-bugzilla#178)

crazyscientist · crobinso · commit 7798f8176b65 · 2023-09-06T10:47:52.000-04:00
Instead of replacing the substring 'xmlrpc.cgi' in the Bugzilla URL, the URL is now
constructed by explicitly using the `netloc` of the Bugzilla URL.
diff --git a/bugzilla/bug.py b/bugzilla/bug.py
@@ -6,6 +6,7 @@
 
 import copy
 from logging import getLogger
+from urllib.parse import urlparse, urlunparse
 
 
 log = getLogger(__name__)
@@ -39,8 +40,16 @@ def __init__(self, bugzilla, bug_id=None, dict=None, autorefresh=False):
             dict["id"] = bug_id
 
         self._update_dict(dict)
-        self.weburl = bugzilla.url.replace('xmlrpc.cgi',
-                                           'show_bug.cgi?id=%i' % self.bug_id)
+        self.weburl = self._generate_weburl()
+
+    def _generate_weburl(self):
+        """
+        Generate the URL to the bug in the web UI
+        """
+        parsed = urlparse(self.bugzilla.url)
+        return urlunparse((parsed.scheme, parsed.netloc,
+                           'show_bug.cgi', '', 'id=%s' % self.bug_id,
+                           ''))
 
     def __str__(self):
         """
diff --git a/tests/data/clioutput/test_query2.txt b/tests/data/clioutput/test_query2.txt
@@ -57,7 +57,7 @@ ATTRIBUTE[target_milestone]: rc
 ATTRIBUTE[target_release]: ['---']
 ATTRIBUTE[url]: 
 ATTRIBUTE[version]: ['5.8']
-ATTRIBUTE[weburl]: https:///TESTSUITEMOCK
+ATTRIBUTE[weburl]: https:///show_bug.cgi?id=1165434
 ATTRIBUTE[whiteboard]: genericwhiteboard
 
 
diff --git a/tests/test_api_bug.py b/tests/test_api_bug.py
@@ -184,3 +184,12 @@ def _get_fake_bug(apiname):
     attachments = bug.get_attachments()
     bug.attachments = attachments
     assert [469147, 470041, 502352] == bug.get_attachment_ids()
+
+
+def test_bug_weburl():
+    fakebz = tests.mockbackend.make_bz(
+        bug_get_args=None,
+        bug_get_return="data/mockreturn/test_getbug_rhel.txt")
+    bug_id = 1165434
+    bug = fakebz.getbug(bug_id)
+    assert bug.weburl == f"https:///show_bug.cgi?id={bug_id}"
