Retry Windows sandbox runner logon once on error 1056 (#49325) · just-every/code@26dd19e · GitHub
Skip to content

Commit 26dd19e

Browse files
zm-oaicopyberry
authored andcommitted
Retry Windows sandbox runner logon once on error 1056 (openai#49325)
## Why `CreateProcessWithLogonW` failures with `ERROR_SERVICE_ALREADY_RUNNING` (1056) previously aborted sandbox startup without retrying. At this stage, neither the runner nor the user command has started, so retrying does not replay the command. ## What changed Retry runner creation once with the same sandbox credentials when logon returns error 1056. Propagate a second failure without refreshing credentials, and keep child startup errors with the same code ineligible for this retry. ## Testing Add regression tests for recovery, the two-attempt limit, and exclusion of child startup failures. Add a unified exec test that injects a logon failure, verifies that the retry preserves the original request and credentials, and checks that the command runs exactly once. GitOrigin-RevId: 78def6cdb93bf32f9b4a3e398cd16de83286fec4
1 parent b1e7296 commit 26dd19e

2 files changed

Lines changed: 180 additions & 11 deletions

File tree

‎codex-rs/windows-sandbox-rs/src/elevated/runner_client.rs‎

Lines changed: 105 additions & 3 deletions

‎codex-rs/windows-sandbox-rs/src/unified_exec/backends/elevated_tests.rs‎

Lines changed: 75 additions & 8 deletions

0 commit comments

Comments
 (0)