FilesExpand file tree

 main

/

IncorrectComparisonUsingIs.ql

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

27 lines (25 loc) · 749 Bytes

 main

/

IncorrectComparisonUsingIs.ql

Copy path

Top

File metadata and controls

• Code
• Blame

27 lines (25 loc) · 749 Bytes

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

/**

* @name Comparison using is when operands support `__eq__`

* @description Comparison using 'is' when equivalence is not the same as identity

* @kind problem

* @tags reliability

* correctness

* @problem.severity warning

* @sub-severity low

* @precision high

* @id py/comparison-using-is

*/

import python

import IsComparisons

from Compare comp, Cmpop op, ClassValue c, string alt

where

invalid_portable_is_comparison(comp, op, c) and

not cpython_interned_constant(comp.getASubExpression()) and

(

op instanceof Is and alt = "=="

or

op instanceof IsNot and alt = "!="

)

select comp,

"Values compared using '" + op.getSymbol() +

"' when equivalence is not the same as identity. Use '" + alt + "' instead."