Ports are out of sync with upstream watermarks-remover · Issue #29 · ivanusto/unmark-web · GitHub
Skip to content

Ports are out of sync with upstream watermarks-remover #29

Closed

Description

@github-actions

Checked against upstream 258cf20. Workflow run

Parity suite is failing

The JavaScript engines no longer produce the same output as upstream for cases the fixtures cover. Read the run log for the failing cases, port the change into the engine it belongs to (js/layer_a.js, js/image_meta.js, js/av_meta.js, js/stylometry.js or js/gumbel.js), and add fixtures for anything new.

Upstream sources changed

5 of 12 upstream sources changed since these ports were last synced.

Source Recorded Now History
watermarks-remover/service/scripts/image_meta.py bd5d9f19f370 679f73ce5562 commits
watermarks-remover/service/scripts/container_meta.py#data-uris (one definition only) 9efdac5d66d4 758a091b46e8 commits
watermarks-remover/service/scripts/container_meta.py#tag-blocks (one definition only) 9554a5fb0015 057d8d9d8cca commits
watermarks-remover/service/scripts/container_meta.py#markdown (one definition only) 868ad8818b39 fa4275b3086a commits
watermarks-remover/service/scripts/container_meta.py#html (one definition only) 8a2c43570b2d c4cc3a1d2b3b commits

Files in this repository that mirror the changed sources:

  • js/image_meta.js
  • tests/test_image_meta_parity.py
  • js/container_meta.js
  • tests/test_container_meta_parity.py

Re-port the affected logic, then update sha256 in scripts/upstream-sources.json in the same commit so this check goes quiet again.

If the parity suite is still green, the change is probably additive: a new format or option the fixtures do not reach. Add fixtures covering it, or the gap stays invisible the next time too.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions