Comparing master...saturated_ullage · iotium/code_on_github · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iotium/code_on_github
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: iotium/code_on_github
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: saturated_ullage
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 14 files changed
  • 1 contributor

Commits on Nov 3, 2014

  1. started work on making ullage saturated

    uncomplete, added get_P_from_mm_T. encountered what looks like a big
    error in previous code -> will switch back to that and fix it to see
    what happens.
    iotium committed Nov 3, 2014
    Configuration menu
    Copy the full SHA
    a81c4f4 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2014

  1. minor error control tweaks

    nothing major
    iotium committed Nov 6, 2014
    Configuration menu
    Copy the full SHA
    d90304e View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2014

  1. code now really uses saturated, 2-phase ullage

    introduced new get_P function, completely re-did Vdot solution
    function. Added a 6th variable (U_tg).
    iotium committed Nov 10, 2014
    Configuration menu
    Copy the full SHA
    db47b18 View commit details
    Browse the repository at this point in the history
  2. found another error about sat. assumption

    I was calculating rho_tg, T_tg assuming Q = 1, I switched it to use
    U_tg/m_tg instead and get actual Q.
    iotium committed Nov 10, 2014
    Configuration menu
    Copy the full SHA
    67a7edf View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2014

  1. improved N2O fits for saturation properties

    now it runs faster than using refprop
    iotium committed Nov 11, 2014
    Configuration menu
    Copy the full SHA
    6503916 View commit details
    Browse the repository at this point in the history
  2. added PDT table generation code

    also found a minor error and fixed it in bubble_growth
    iotium committed Nov 11, 2014
    Configuration menu
    Copy the full SHA
    8cd5c3e View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2014

  1. new PDT_table code, qinterp2

    new code for generating PDT_table, also started using qinterp2 to
    access PDT_table (much faster than interp2).
    iotium committed Nov 12, 2014
    Configuration menu
    Copy the full SHA
    1b10591 View commit details
    Browse the repository at this point in the history
  2. edited dyer_flow to reduce refprop calls

    now more things are passed from bubble_growth. note that dyer_flow
    probably won’t work with other tank modeling codes now.
    iotium committed Nov 12, 2014
    Configuration menu
    Copy the full SHA
    e873f5c View commit details
    Browse the repository at this point in the history
  3. reduce number of refpropm calls

    combined 2 pairs of calls down to 2 calls
    iotium committed Nov 12, 2014
    Configuration menu
    Copy the full SHA
    8cfdb34 View commit details
    Browse the repository at this point in the history
  4. eliminated another refprop call

    now the code from get_P is duplicated (using PDT_table instead of
    refprop)
    iotium committed Nov 12, 2014
    Configuration menu
    Copy the full SHA
    ee852e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2014

  1. minor changes

    made it so save interval is time based, not loop index based. not sure
    what else I did…
    iotium committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    7dd9c15 View commit details
    Browse the repository at this point in the history
Loading