{{ message }}
Repository navigation
FlashPack - #12700
Merged
Merged
FlashPack#12700
Conversation
Contributor
hlky
marked this pull request as ready for review
January 19, 2026 11:51
4 of 5 tasks
|
@DN6 @sayakpaul what needs to be done prior to merging this PR? |
DN6
reviewed
Feb 12, 2026
DN6
left a comment
Collaborator
There was a problem hiding this comment.
Looking good 👍🏽 Some minor comments. Could we also add a test for saving/loading and setting device_map with a dummy model.
hlky
commented
Feb 14, 2026
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
DN6
reviewed
Feb 24, 2026
Comment on lines
+418
to
+420
| if class_name.startswith("FlashPack"): | ||
| class_name = class_name.removeprefix("FlashPack") | ||
|
|
Collaborator
There was a problem hiding this comment.
Don't think this path would ever run since diffusers isn't modifying the class name when saving flash pack models. Think we can remove this.
Contributor
Author
There was a problem hiding this comment.
The original code modifies the class name when saving models
DN6
approved these changes
Apr 13, 2026
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
@bot /style |
Contributor
Closed
terarachang
pushed a commit
to terarachang/diffusers
that referenced
this pull request
Apr 30, 2026
* FlashPack * setup * save_pretrained * dtype is property * destination_path * logging * pipeline * ruff * flashpack_kwargs * download * Fix docstring * Apply suggestions from code review Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com> * tests * ignore_cleanup_errors * -load_flashpack_checkpoint * Apply style fixes --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Adds support for FlashPack
FlashPack could be used as weight format only (see:
load_flashpack_checkpoint) - keeping only weight format code would be a cleaner integration, the model loading is indeed faster[1] however part of the performance difference seems to be just due to the complexity of existingfrom_pretrainedcode, for example I noticed that_caching_allocator_warmupslows things down, alsoempty_device_cacheis called in_load_pretrained_modelwhereas FlashPack's code doesn't thus the empty cache time is excluded from FlashPack's benchmark results.is_flashpack_availablecheck logging, etc)silent,num_streams,use_distributed_loadingetc.)Benchmark
Changes from FlashPack's version:
transformersrelated code[1] For
bfloat16- withfloat16existing code appears to be fasterWho can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.