fix: add support for extraEnv specification on network node root containers by nathanklick · Pull Request #886 · hashgraph/full-stack-testing · GitHub
Skip to content

fix: add support for extraEnv specification on network node root containers#886

Merged
nathanklick merged 1 commit into
mainfrom
00884-Support-ExtraEnv
Jun 12, 2024
Merged

fix: add support for extraEnv specification on network node root containers#886
nathanklick merged 1 commit into
mainfrom
00884-Support-ExtraEnv

Conversation

@nathanklick

Copy link
Copy Markdown
Member

Description

This pull request changes the following:

  • Adds support for the specification of extraEnv on a per node basis on the network node root container.

Related Issues

…ainers

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick nathanklick self-assigned this Jun 12, 2024
@nathanklick nathanklick added New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Jun 12, 2024
@github-actions

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.17%. Comparing base (2ab4080) to head (7f1e378).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #886   +/-   ##
=========================================
  Coverage     67.17%   67.17%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1319     1319           
  Branches        157      157           
=========================================
  Hits            886      886           
  Misses          370      370           
  Partials         63       63           

Impacted file tree graph

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nathanklick nathanklick merged commit 96ea24a into main Jun 12, 2024
@nathanklick nathanklick deleted the 00884-Support-ExtraEnv branch June 12, 2024 19:01
swirlds-automation added a commit that referenced this pull request Jun 12, 2024
## [0.28.1](v0.28.0...v0.28.1) (2024-06-12)

### Bug Fixes

* add support for extraEnv specification on network node root containers ([#886](#886)) ([96ea24a](96ea24a))
* remove hardcoded jdwp java agent ([#885](#885)) ([2ab4080](2ab4080))
@swirlds-automation

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Charts[Network]: Add support for extraEnv on the network node containers

2 participants