Duplicate/Unexpected call detail::toUtf8 · Issue #100 · gulrak/filesystem · GitHub
Skip to content

Duplicate/Unexpected call detail::toUtf8 #100

Description

@phprus

The path constructor already uses detail::toUtf8.

Duplicate call (and possible wrong in wchar_t environment):

template <class Source>
inline path& path::append(const Source& source)
{
    return this->operator/=(path(detail::toUtf8(source)));
}

and:

template <class EcharT>
inline path::path_type_EcharT<EcharT>& path::operator+=(EcharT x)
{
    std::basic_string<EcharT> part(1, x);
    concat(detail::toUtf8(part));
    return *this;
}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    available on masterFix is done on master branch, issue closed on next releaseenhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions