feat: Triger bidi conformance tests#1757
Conversation
reversed not needed Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request enhances test coverage by introducing conformance tests for bidirectional reads and writes, and refactors the AsyncGrpcClient. It also addresses minor metadata handling issues in async_read_object_stream.py and async_write_object_stream.py. A medium-severity vulnerability was identified concerning the create_insecure_channel feature, which, despite being for testing, could lead to unencrypted data transmission in production if misused. It is recommended to implement safeguards, such as an environment variable guard, to prevent this. The addition of _utils.py further supports these conformance tests.
|
📢 Migration Notice: 📢 This library is moving to the google-cloud-python monorepo soon. We kept this PR open due to recent activity. We would like to finalize this PR so it can be merged if it is critical. If we don't hear from the PR author, we will close this PR in the next few days. The PR can then be re-opened in the monorepo once the migration is complete and work can continue there. |
…/python-storage into triger_bidi_conformance_tests

feat: Triger bidi conformance tests
Changes / fixes
.closeon it. (this leads to reading the same error message again and again until retry loop times out)test_so that pytest pickup the tests)blocked because of b/489420625