{{ message }}
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
feat: add support for partial list buckets#1606
Merged
Merged
Conversation
product-auto-label
Bot
added
the
api: storage
Contributor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for partial success in list_buckets, which is a valuable addition. However, I've found a couple of critical issues that need to be addressed before this can be merged. There's an indentation error in a new helper function that will cause a runtime failure, and the new unit test is broken due to an incorrect mock setup and is also incomplete. I've also identified an opportunity to refactor the list_buckets method to reduce code duplication, which will improve maintainability.
chandra-siri
suggested changes
Nov 10, 2025
Collaborator
|
@Pulkit0110 Also include system tests. (Which can be done by hitting storage testbench) |
Contributor
Author
Pulkit0110
force-pushed
the
partial-list-buckets
branch
from
e725a14 to
4c7e308
Compare
chandra-siri
suggested changes
Nov 11, 2025
chandra-siri
approved these changes
Nov 12, 2025
Pulkit0110
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
Pulkit0110
pushed a commit
that referenced
this pull request
Nov 17, 2025
🤖 I have created a release *beep* *boop* --- ## [3.6.0](v3.5.0...v3.6.0) (2025-11-17) ### Features * Add support for partial list buckets ([#1606](#1606)) ([92fc2b0](92fc2b0)) * Make return_partial_success and unreachable fields public for list Bucket ([#1601](#1601)) ([323cddd](323cddd)) * **zb-experimental:** Add async write object stream ([5ab8103](5ab8103)) * **zb-experimental:** Add async write object stream ([#1612](#1612)) ([5ab8103](5ab8103)) ### Bug Fixes * Dont pass credentials to StorageClient ([#1608](#1608)) ([195d644](195d644)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Mar 9, 2026
🤖 I have created a release *beep* *boop* --- ## [3.6.0](googleapis/python-storage@v3.5.0...v3.6.0) (2025-11-17) ### Features * Add support for partial list buckets ([#1606](googleapis/python-storage#1606)) ([92fc2b0](googleapis/python-storage@92fc2b0)) * Make return_partial_success and unreachable fields public for list Bucket ([#1601](googleapis/python-storage#1601)) ([323cddd](googleapis/python-storage@323cddd)) * **zb-experimental:** Add async write object stream ([5ab8103](googleapis/python-storage@5ab8103)) * **zb-experimental:** Add async write object stream ([#1612](googleapis/python-storage#1612)) ([5ab8103](googleapis/python-storage@5ab8103)) ### Bug Fixes * Dont pass credentials to StorageClient ([#1608](googleapis/python-storage#1608)) ([195d644](googleapis/python-storage@195d644)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for partial list buckets