feat: fgac support and samples by asthamohta · Pull Request #867 · googleapis/python-spanner · GitHub
Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

feat: fgac support and samples#867

Merged
asthamohta merged 8 commits into
googleapis:mainfrom
asthamohta:fgac-final
Dec 13, 2022
Merged

feat: fgac support and samples#867
asthamohta merged 8 commits into
googleapis:mainfrom
asthamohta:fgac-final

Conversation

@asthamohta

@asthamohta asthamohta commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

enable_fine_grained_access sample requires service account to work, so skipping integration tests for the same.

@asthamohta asthamohta requested a review from a team as a code owner December 13, 2022 05:21
@asthamohta asthamohta requested review from a team and leahecole December 13, 2022 05:21
@snippet-bot

snippet-bot Bot commented Dec 13, 2022

Copy link
Copy Markdown

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Dec 13, 2022

@rajatbhatta rajatbhatta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few minor comments.

Comment thread google/cloud/spanner_v1/database.py Outdated
Comment thread google/cloud/spanner_v1/pool.py
Comment thread samples/samples/snippets.py
Comment thread samples/samples/snippets_test.py
@asthamohta asthamohta added the automerge Merge the pull request once unit tests and other checks pass. label Dec 13, 2022
@asthamohta asthamohta enabled auto-merge (squash) December 13, 2022 11:49
@asthamohta asthamohta merged commit 24fa244 into googleapis:main Dec 13, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants