feat: added get_shards and print_gcs_document_tree functions by galdawave · Pull Request #7 · googleapis/python-documentai-toolbox · GitHub
Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: added get_shards and print_gcs_document_tree functions#7

Merged
galdawave merged 12 commits into
mainfrom
missing_functions
Oct 3, 2022
Merged

feat: added get_shards and print_gcs_document_tree functions#7
galdawave merged 12 commits into
mainfrom
missing_functions

Conversation

@galdawave

@galdawave galdawave commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

BEGIN_COMMIT_OVERRIDE
chore: added get_shards and print_gcs_document_tree functions
END_COMMIT_OVERRIDE

@galdawave galdawave requested a review from a team September 27, 2022 21:56
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Sep 27, 2022
@galdawave galdawave requested a review from dizcology September 29, 2022 18:43
Comment thread google/cloud/documentai_toolbox/wrappers/document_wrapper.py Outdated
Comment thread google/cloud/documentai_toolbox/wrappers/document_wrapper.py Outdated
Comment thread google/cloud/documentai_toolbox/wrappers/document_wrapper.py Outdated
Comment thread tests/unit/test_document_wrapper.py Outdated
Comment thread tests/unit/test_document_wrapper.py Outdated
Comment thread tests/unit/test_document_wrapper.py
@galdawave galdawave requested a review from dizcology September 30, 2022 17:33

@dizcology dizcology left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last comment about naming confusion between shards, documentai.Documents and DocumentWrapper.

Comment thread google/cloud/documentai_toolbox/wrappers/document_wrapper.py Outdated
@galdawave galdawave merged commit b5ac4ca into main Oct 3, 2022
@galdawave galdawave deleted the missing_functions branch October 3, 2022 17:31
@galdawave galdawave changed the title feat: added get_document and list_document functions feat: added get_shards and print_gcs_document_tree functions Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants