feat: added docproto to AnnotateFile convertor by galdawave · Pull Request #63 · googleapis/python-documentai-toolbox · GitHub
Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: added docproto to AnnotateFile convertor#63

Merged
holtskinner merged 8 commits into
googleapis:mainfrom
galdawave:doc_to_vision
Feb 24, 2023
Merged

feat: added docproto to AnnotateFile convertor#63
holtskinner merged 8 commits into
googleapis:mainfrom
galdawave:doc_to_vision

Conversation

@galdawave

@galdawave galdawave commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@galdawave galdawave requested review from a team February 22, 2023 22:27
@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Feb 22, 2023
holtskinner
holtskinner approved these changes Feb 22, 2023
View reviewed changes
Comment thread google/cloud/documentai_toolbox/converters/vision_helpers.py
Comment thread google/cloud/documentai_toolbox/wrappers/document.py Outdated
@holtskinner holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 22, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 22, 2023
@holtskinner

holtskinner commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

@galdawave galdawave requested a review from a team as a code owner February 23, 2023 20:17
@galdawave galdawave requested a review from atulep February 23, 2023 20:17
@snippet-bot

snippet-bot Bot commented Feb 23, 2023 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@galdawave

galdawave commented Feb 23, 2023

Copy link
Copy Markdown
Contributor Author

holtskinner
holtskinner approved these changes Feb 23, 2023
View reviewed changes
Comment thread samples/snippets/convert_document_to_vision_sample.py
@holtskinner holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2023
@holtskinner holtskinner merged commit f6dd89a into googleapis:main Feb 24, 2023
@release-please release-please Bot mentioned this pull request Feb 27, 2023
Merged
@release-please release-please Bot mentioned this pull request Apr 7, 2023
Closed
@galdawave galdawave deleted the doc_to_vision branch June 2, 2023 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atulep atulep Awaiting requested review from atulep atulep is a code owner automatically assigned from googleapis/python-samples-reviewers
1 more reviewer
@holtskinner holtskinner holtskinner approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@galdawave @holtskinner