{{ message }}
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: Added Support for Form Fields#48
Merged
Merged
Conversation
galdawave
approved these changes
Feb 13, 2023
galdawave
left a comment
galdawave
left a comment
Contributor
There was a problem hiding this comment.
Other then the forgotten return type this looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
_text_from_element_with_layout()to_text_from_layout()and removed Union to allow for FormField name/value parsing