{{ message }}
This repository was archived by the owner on Feb 23, 2026. It is now read-only.
feat: Add support for rest/ token in x-goog-api-client header#189
Merged
Conversation
This is required for (DI)REGAPIC clients, like GCE client.
google-cla
Bot
added
the
cla: yes
Contributor
Author
software-dov
approved these changes
May 17, 2021
Comment on lines
70
to
+76
| self.python_version = python_version | ||
| self.grpc_version = grpc_version | ||
| self.api_core_version = api_core_version | ||
| self.gapic_version = gapic_version | ||
| self.client_library_version = client_library_version | ||
| self.user_agent = user_agent | ||
| self.rest_version = rest_version |
Contributor
There was a problem hiding this comment.
Should there be a check that either rest_version XOR grpc_version is set?
Contributor
Author
There was a problem hiding this comment.
Sounds reasonable to me, I was thinking about the same thing, but then decided that it would be safer to not add something like tha to a GA'ed library. If you feel strong about it, I can add it. Should I?
Contributor
There was a problem hiding this comment.
I don't feel strongly about it, but it seems like a reasonable thing for someone looking at the fields to expect.
Contributor
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for (DI)REGAPIC clients, like GCE client.