{{ message }}
chore(toolbox-core): Use Toolbox server dev build for integration tests - #298
Draft
anubhav756 wants to merge 4 commits into
Draft
anubhav756 wants to merge 4 commits into
anubhav756 wants to merge 4 commits into
Conversation
anubhav756
changed the title
anubhav756
marked this pull request as ready for review
July 1, 2025 11:27
anubhav756
force-pushed
the
anubhav-opt-params-test
branch
from
July 1, 2025 13:30
8000adc to
3212d63
Compare
anubhav756
changed the title
anubhav756
force-pushed
the
anubhav-opt-params-test
branch
3 times, most recently
from
July 2, 2025 13:43
fa6b4f4 to
ca766a3
Compare
anubhav756
force-pushed
the
anubhav-optional-params
branch
2 times, most recently
from
July 2, 2025 14:22
d6a153e to
57aeeb2
Compare
anubhav756
force-pushed
the
anubhav-opt-params-test
branch
from
July 2, 2025 14:30
ca766a3 to
2ccb261
Compare
anubhav756
force-pushed
the
anubhav-optional-params
branch
2 times, most recently
from
July 2, 2025 16:17
1c598a4 to
90f7472
Compare
anubhav756
force-pushed
the
anubhav-opt-params-test
branch
from
July 2, 2025 16:18
2ccb261 to
9bee6e5
Compare
anubhav756
force-pushed
the
anubhav-optional-params
branch
from
July 2, 2025 17:08
90f7472 to
7e38892
Compare
anubhav756
force-pushed
the
anubhav-opt-params-test
branch
3 times, most recently
from
July 2, 2025 17:21
c66ade4 to
f811574
Compare
kurtisvg
previously approved these changes
Jul 2, 2025
anubhav756
force-pushed
the
anubhav-opt-params-test
branch
2 times, most recently
from
July 2, 2025 19:59
3287116 to
1a0b5e7
Compare
Contributor
Contributor
Author
anubhav756
force-pushed
the
anubhav-opt-params-test
branch
from
July 7, 2025 06:57
1a0b5e7 to
dcc035c
Compare
anubhav756
force-pushed
the
anubhav-opt-params-test
branch
2 times, most recently
from
July 21, 2025 07:14
1f0976b to
277bdb9
Compare
anubhav756
force-pushed
the
anubhav-opt-params-test
branch
from
August 18, 2025 13:18
277bdb9 to
2e746cb
Compare
anubhav756
marked this pull request as draft
September 4, 2025 13:08
anubhav756
added
the
priority: p3
twishabansal
removed their request for review
June 11, 2026 17:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the integration tests to use a dev build of the toolbox server from the
mainbranch.Currently, integration tests are conducted against a released version of the toolbox server. This poses a challenge when SDK and server features, such as optional parameters, are developed and released concurrently. In such scenarios, integration tests for the SDK will fail as the corresponding server-side support is absent in the released version.
To address this, this change modifies the server download for integration tests to pull from the GCS bucket for toolbox dev builds, specifically from the
mainbranch. This ensures that the SDK is tested against the latest server version, which should ideally be stable and backward-compatible.Flexibility in Versioning
For situations where new SDK features do not have a dependency on server-side changes, the
TOOLBOX_VERSIONand the newly introducedTOOLBOX_BUCKETenv vars in theintegration.cloudbuild.yamlconfig can be adjusted. This allows for switching back to a specific released version of the toolbox server for integration testing if needed.Note
This PR removes the automatic
vprefix from the version when constructing the blob download URL. Consequently, if you need to test against a released version (e.g.,0.8.0), theTOOLBOX_VERSIONmust be set tov0.8.0. This change accommodates version values that do not have a v prefix, such asmain.Note
The integration tests would currently fail due to a known issue with the optional parameters implementation with the server dev build [#771]