feat: removing migrated grpc- and proto- modules from repository by suztomo · Pull Request #592 · googleapis/java-iam · GitHub
Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

feat: removing migrated grpc- and proto- modules from repository#592

Merged
suztomo merged 12 commits into
mainfrom
remove_moved_artifacts
Jan 10, 2023
Merged

feat: removing migrated grpc- and proto- modules from repository#592
suztomo merged 12 commits into
mainfrom
remove_moved_artifacts

Conversation

@suztomo

@suztomo suztomo commented Jan 10, 2023

Copy link
Copy Markdown
Member

The proto- and grpc- modules have been migrated to
https://github.com/googleapis/gapic-generator-java/tree/main/java-iam

@suztomo suztomo requested a review from a team January 10, 2023 15:19
@product-auto-label product-auto-label Bot added the size: xl Pull request size is extra large. label Jan 10, 2023
@generated-files-bot

generated-files-bot Bot commented Jan 10, 2023

Copy link
Copy Markdown

@product-auto-label product-auto-label Bot added the api: iam Issues related to the googleapis/java-iam API. label Jan 10, 2023
@suztomo suztomo changed the title chore: removed migrated grpc- and proto- modules chore: removing migrated grpc- and proto- modules Jan 10, 2023
@suztomo suztomo force-pushed the remove_moved_artifacts branch from e05da1b to 7d42924 Compare January 10, 2023 15:36
Comment thread .repo-metadata.json
"repo_short": "java-iam",
"library_type": "OTHER",
"distribution_name": "com.google.api.grpc:proto-google-iam-v1",
"distribution_name": "com.google.cloud:google-iam-policy",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Memo: OwlBot Postprocessor modifies versions.txt and other files based on repo-metadata.json.

https://github.com/googleapis/synthtool/blob/7197a001ffb6d8ce7b0b9b11c280f0c536c1033a/docker/owlbot/java/src/fix-poms.py#L279

@suztomo suztomo requested a review from ddixit14 January 10, 2023 15:47
mvn clean install -B -q -DskipTests=true

export NAME=proto-google-iam-v1
export NAME=google-iam-policy

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OwlBot PostProcessor made this change, based on the repo-metadata.json change.

mvn clean install -B -q -DskipTests=true

export NAME=proto-google-iam-v1
export NAME=google-iam-policy

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OwlBot PostProcessor made this change, based on the repo-metadata.json change.

@suztomo suztomo changed the title chore: removing migrated grpc- and proto- modules feat: removing migrated grpc- and proto- modules from repository Jan 10, 2023
Comment thread pom.xml
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>google-iam-parent</artifactId>
<artifactId>google-iam-policy-parent</artifactId>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the artifact ID to avoid conflict with the one in gapic-generator-java/java-iam.

@suztomo suztomo merged commit 9c4b9aa into main Jan 10, 2023
@suztomo suztomo deleted the remove_moved_artifacts branch January 10, 2023 15:59
@suztomo

suztomo commented Jan 10, 2023

Copy link
Copy Markdown
Member Author

gcf-merge-on-green Bot pushed a commit that referenced this pull request Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: iam Issues related to the googleapis/java-iam API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants