HttpResponse uses contains where it needs equals · Issue #842 · googleapis/google-http-java-client · GitHub
Skip to content

HttpResponse uses contains where it needs equals #842

Closed
#843
Closed
HttpResponse uses contains where it needs equals#842
#843
Assignees
chingor13
Labels
good first issueThis issue is a good place to started contributing to this repository.help wantedWe'd love to have community involvement on this issue.priority: p2Moderately-important priority. Fix may not be included in next release.semver: patchA minor bug fix or small change.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@elharo
elharo
opened on Oct 14, 2019
        if (!returnRawInputStream
             && contentEncoding != null	              && contentEncoding != null
             && contentEncoding.contains("gzip")) {

"contains" is incorrect. This should be equals or perhaps equalsIgnoreCase with a trim, or something like that. However it shouldn't fire on foogzipbar.

Metadata

Metadata

Assignees

Labels

good first issueThis issue is a good place to started contributing to this repository.help wantedWe'd love to have community involvement on this issue.priority: p2Moderately-important priority. Fix may not be included in next release.semver: patchA minor bug fix or small change.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions