You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Split out from #9429, which works around this with an .eslintrc.json override.
Problem
Four generator templates emit code that violates the repo's root ESLint config, so every librarian regeneration PR fails bin/linter.mjs --strict (#9427 had 59 errors).
let routingParameter = {} is only ever Object.assign'd — plain bug
Latent debt
bin/linter.mjs is diff-scoped (eslint.lintFiles() on changed files only), so checked-in generated code already carries violations CI never sees. Untouched files on main today:
Fix the four templates (cjs + esm) and update generator baselines
Cut a new gapic-generator-v* tag
Bump version + checksum in librarian.yaml
Drop the @typescript-eslint/no-floating-promises and prefer-const lines from the generated-GAPIC override in .eslintrc.json
Note the two promise/* lines are a restoration of pre-#8458 behavior (the promise plugin was added to the root config in #8446, three weeks after per-package root: true configs were deleted), so those can stay off permanently or be dropped in the same step — either is defensible.
Activity
chore(lint): document removal condition for generated-GAPIC override