{{ message }}
This repository was archived by the owner on May 12, 2026. It is now read-only.
feat: Add Credential Information to GoogleCredential classes#1791
Merged
Conversation
lqiu96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
lqiu96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
zhumin8
reviewed
Aug 27, 2025
zhumin8
left a comment
zhumin8
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just a few nit comments.
A question on UserCredentials: the design says to use account from credential json if present. I don't see relevant logic in user cred. What is the reason for this?
lqiu96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Member
Author
zhumin8
reviewed
Aug 28, 2025
zhumin8
left a comment
zhumin8
left a comment
Contributor
There was a problem hiding this comment.
A few nits, non-blocking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See b/360939866 for more info.
Returns a mapping of how the Credential classes were initialized: