fix: remove faulty version matcher in setup.py by con-f-use · Pull Request #2152 · googleapis/google-api-python-client · GitHub
Skip to content

fix: remove faulty version matcher in setup.py#2152

Merged
gcf-merge-on-green[bot] merged 2 commits into
googleapis:mainfrom
con-f-use:patch-1
Jun 6, 2023
Merged

fix: remove faulty version matcher in setup.py#2152
gcf-merge-on-green[bot] merged 2 commits into
googleapis:mainfrom
con-f-use:patch-1

Conversation

@con-f-use

@con-f-use con-f-use commented Jun 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

httplib2<1dev is not a valid version matcher (edit: it is valid, just doesn't parse with distlib) in the sense of PEP 440.

The canonical public version identifiers MUST comply with the following scheme:
[N!]N(.N)*[{a|b|rc}N][.postN][.devN]

It is also considered bad practice to have an upper bound on package versions and installers like pip do not consider development versions in any case (unless explicitly told to).

Fixes #2151

@con-f-use con-f-use requested a review from a team June 6, 2023 11:43
@google-cla

google-cla Bot commented Jun 6, 2023

Copy link
Copy Markdown

@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Jun 6, 2023
@con-f-use

con-f-use commented Jun 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@con-f-use @bn-jbischko
fix: faulty version matchers in setup.py
532248c 
`httplib2<1dev` is not a valid version matcher in the sense of PEP 440.

fixes #2151
@parthea parthea changed the title remove faulty version matcher in setup.py fix: remove faulty version matcher in setup.py Jun 6, 2023
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 6, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 6, 2023
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 6, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@parthea parthea added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 6, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 6, 2023
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 0a865da into googleapis:main Jun 6, 2023
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 6, 2023
@release-please release-please Bot mentioned this pull request Jun 6, 2023
Merged
@con-f-use con-f-use deleted the patch-1 branch June 6, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<1dev is not a valid matcher for Python package versions in setup.py!

3 participants

@con-f-use @parthea @yoshi-kokoro