{{ message }}
This repository was archived by the owner on Mar 26, 2026. It is now read-only.
fix: timeouts are handled by rest clients, retries silently ignored#976
Merged
Merged
Conversation
software-dov
requested review from
a team,
busunkim96,
vam-google and
vchudnov-g
google-cla
Bot
added
the
cla: yes
busunkim96
approved these changes
Aug 20, 2021
Contributor
There was a problem hiding this comment.
Is the plan to handle retries at a later date?
It looks like the two manually authored REST clients BigQuery and Storage have their own retry class that uses google-api-core's retry object. It might be nicer to create a REST equivalent of _GapicCallable for REGAPIC instead of interacting with AuthorizedSession directly.
Contributor
Author
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes hand tests