fix: fix datetime comparison unit tests by busunkim96 · Pull Request #898 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: fix datetime comparison unit tests#898

Merged
gcf-merge-on-green[bot] merged 2 commits into
masterfrom
fix-datetime-comparisons
May 20, 2021
Merged

fix: fix datetime comparison unit tests#898
gcf-merge-on-green[bot] merged 2 commits into
masterfrom
fix-datetime-comparisons

Conversation

@busunkim96

@busunkim96 busunkim96 commented May 19, 2021

Copy link
Copy Markdown
Contributor

Fixes #897

The string ident changed to have an _pb2 in #851. If there's a more robust way to do this comparison please let me know.

@busunkim96 busunkim96 requested review from a team and software-dov May 19, 2021 22:33
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2021
@busunkim96 busunkim96 requested a review from parthea May 19, 2021 22:33
@codecov

codecov Bot commented May 19, 2021

Copy link
Copy Markdown

@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2021
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 81932a2 into master May 20, 2021
@gcf-merge-on-green gcf-merge-on-green Bot deleted the fix-datetime-comparisons branch May 20, 2021 14:52
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comparison fails for unit tests with timestamps

2 participants