fix: remove support for google-api-core<1.26.0 by busunkim96 · Pull Request #893 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: remove support for google-api-core<1.26.0#893

Merged
busunkim96 merged 2 commits into
masterfrom
remove-old-api-core-path
May 19, 2021
Merged

fix: remove support for google-api-core<1.26.0#893
busunkim96 merged 2 commits into
masterfrom
remove-old-api-core-path

Conversation

@busunkim96

@busunkim96 busunkim96 commented May 19, 2021

Copy link
Copy Markdown
Contributor

Drop support for google-api-core < 1.26.0. This code was originally added in #774.

This should unblock the coverage failures in the generated showcase unit tests for #888.

@busunkim96 busunkim96 requested a review from a team May 19, 2021 20:18
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2021
@codecov

codecov Bot commented May 19, 2021

Copy link
Copy Markdown

@tseaver tseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to be able to drop support for the older google-auth versions, too.

@busunkim96

Copy link
Copy Markdown
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants