fix: consistently use _pb2 identifier by busunkim96 · Pull Request #883 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: consistently use _pb2 identifier#883

Merged
gcf-merge-on-green[bot] merged 5 commits into
masterfrom
fix-pb2-refs
May 12, 2021
Merged

fix: consistently use _pb2 identifier#883
gcf-merge-on-green[bot] merged 5 commits into
masterfrom
fix-pb2-refs

Conversation

@busunkim96

@busunkim96 busunkim96 commented May 12, 2021

Copy link
Copy Markdown
Contributor

Small change to fix bug noticed in googleapis/python-dialogflow#288.

The import was from google.rpc import status_pb2 but code expected gr_status

@busunkim96 busunkim96 requested a review from a team May 12, 2021 21:19
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 12, 2021
@codecov

codecov Bot commented May 12, 2021

Copy link
Copy Markdown

@software-dov software-dov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a quick test to verify the new behavior?

@busunkim96 busunkim96 requested a review from software-dov May 12, 2021 23:24
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants