fix: use correct retry deadline in publisher methods by plamut · Pull Request #814 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: use correct retry deadline in publisher methods#814

Merged
software-dov merged 3 commits into
googleapis:masterfrom
plamut:iss-794
Mar 19, 2021
Merged

fix: use correct retry deadline in publisher methods#814
software-dov merged 3 commits into
googleapis:masterfrom
plamut:iss-794

Conversation

@plamut

@plamut plamut commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

Fixes #794.

This PR makes sure that correct Retry deadline is used in publisher methods. Should fix googleapis/python-pubsub#303 when the Python PubSub code is re-generated.

@plamut plamut requested a review from a team March 15, 2021 09:10
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2021
@codecov

codecov Bot commented Mar 15, 2021

Copy link
Copy Markdown

@software-dov software-dov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add the same change to the ads template?

@plamut

plamut commented Mar 16, 2021

Copy link
Copy Markdown
Contributor Author

Done, and the same for the async client template, PTAL.

BTW, for future reference, what are ads-templates anyway?

@plamut plamut requested a review from software-dov March 16, 2021 13:07
@software-dov

Copy link
Copy Markdown
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect timeout used when wrapping methods in pubsub_v1 transports Default deadline for publish does not match expectations

2 participants