{{ message }}
This repository was archived by the owner on Mar 26, 2026. It is now read-only.
fix: use correct retry deadline in publisher methods#814
Merged
Conversation
software-dov
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Can you add the same change to the ads template?
Contributor
Author
|
Done, and the same for the async client template, PTAL. BTW, for future reference, what are |
software-dov
approved these changes
Mar 19, 2021
Contributor
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Mar 19, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [0.43.1](https://www.github.com/googleapis/gapic-generator-python/compare/v0.43.0...v0.43.1) (2021-03-19) ### Bug Fixes * use correct retry deadline in publisher methods ([#814](https://www.github.com/googleapis/gapic-generator-python/issues/814)) ([92a2cfc](https://www.github.com/googleapis/gapic-generator-python/commit/92a2cfc47b24c4b1a041d5bbb944d69a67a962a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #794.
This PR makes sure that correct Retry deadline is used in publisher methods. Should fix googleapis/python-pubsub#303 when the Python PubSub code is re-generated.