fix: remove client recv msg limit by busunkim96 · Pull Request #704 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: remove client recv msg limit#704

Merged
busunkim96 merged 2 commits into
masterfrom
remove-client-recv-msg-limit
Dec 10, 2020
Merged

fix: remove client recv msg limit#704
busunkim96 merged 2 commits into
masterfrom
remove-client-recv-msg-limit

Conversation

@busunkim96

Copy link
Copy Markdown
Contributor

Closes #669

Replicates change made in monolithic generator to remove client side size limits.
googleapis/gapic-generator#2900 googleapis/gapic-generator#2905

@busunkim96 busunkim96 requested a review from a team December 10, 2020 00:55
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2020
@busunkim96 busunkim96 changed the title Remove client recv msg limit fix: remove client recv msg limit Dec 10, 2020
@codecov

codecov Bot commented Dec 10, 2020

Copy link
Copy Markdown

@busunkim96 busunkim96 Dec 10, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the options wherever a channel was created, but am not 100% sure if it makes sense here (in the rest transport). @yon-mg could you take a look?

@busunkim96 busunkim96 merged commit 80147ce into master Dec 10, 2020
@busunkim96 busunkim96 deleted the remove-client-recv-msg-limit branch December 10, 2020 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove client-side enforcement of send/recv message size limit

2 participants